Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: fix data too long when convert to bit returns null value #20241

Merged
merged 2 commits into from
Oct 9, 2020
Merged

expression: fix data too long when convert to bit returns null value #20241

merged 2 commits into from
Oct 9, 2020

Conversation

lzmhhh123
Copy link
Contributor

@lzmhhh123 lzmhhh123 commented Sep 27, 2020 •
edited by SunRunAway
Loading

What problem does this PR solve?

Issue Number: close #20118

What is changed and how it works?

How it Works: truncate unsigned int when converting to a specified bit value.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression
    • Consumes more CPU

Release note

  • Fix a problem of data too long when converting from int unsigned it to bit

@lzmhhh123 lzmhhh123 requested a review from a team as a code owner September 27, 2020 05:44
@lzmhhh123 lzmhhh123 requested review from qw4990 and removed request for a team September 27, 2020 05:44
@lzmhhh123 lzmhhh123 added needs-cherry-pick-4.0 sig/execution SIG execution type/bugfix This PR fixes a bug. labels Sep 27, 2020
@lzmhhh123 lzmhhh123 requested a review from XuHuaiyu September 27, 2020 05:45
@lzmhhh123
Copy link
Contributor Author

/run-all-tests

@lzmhhh123
Copy link
Contributor Author

/run-sqllogic-test-1

XuHuaiyu
XuHuaiyu reviewed Sep 28, 2020
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 28, 2020
@XuHuaiyu
Copy link
Contributor

PTAL @qw4990

qw4990
qw4990 approved these changes Oct 9, 2020
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Oct 9, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Oct 9, 2020
@qw4990 qw4990 added the status/can-merge Indicates a PR has been approved by a committer. label Oct 9, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit a7f9d7a into pingcap:master Oct 9, 2020
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Oct 9, 2020
@lzmhhh123 @ti-srebot
cherry pick pingcap#20241 to release-3.0
994f848 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Oct 9, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 in PR #20362

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Oct 9, 2020
@lzmhhh123 @ti-srebot
cherry pick pingcap#20241 to release-4.0
8499dd2 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Oct 9, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #20363

ti-srebot added a commit that referenced this pull request Oct 14, 2020
@ti-srebot
expression: fix data too long when convert to bit returns null value (#…
fc64bf9 
…20241) (#20363)

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
bb7133 pushed a commit that referenced this pull request Nov 11, 2020
@ti-srebot
expression: fix data too long when convert to bit returns null value (#…
300c11b 
…20241) (#20362)
This was referenced Nov 19, 2020
Closed
Merged
@lzmhhh123 lzmhhh123 deleted the bug-fix/fix_insert_ignore_bit branch March 26, 2021 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@qw4990 qw4990 qw4990 approved these changes

Assignees
No one assigned
Labels
component/expression sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bit column insert null value in insert ignore statement
4 participants
@lzmhhh123 @XuHuaiyu @ti-srebot @qw4990