Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: fix data too long when convert to bit returns null value (#20241) #20362

Merged
merged 3 commits into from
Nov 11, 2020
Merged

expression: fix data too long when convert to bit returns null value (#20241) #20362

merged 3 commits into from
Nov 11, 2020

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Oct 9, 2020 •
edited by SunRunAway
Loading

cherry-pick #20241 to release-3.0

What problem does this PR solve?

Issue Number: close #20118

What is changed and how it works?

How it Works: truncate unsigned int when converting to a specified bit value.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression
    • Consumes more CPU

Release note

  • Fix a problem of data too long when converting from int unsigned it to bit

@lzmhhh123 @ti-srebot
cherry pick pingcap#20241 to release-3.0
994f848 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Oct 9, 2020
Merged
@ti-srebot ti-srebot requested review from qw4990 and XuHuaiyu October 9, 2020 06:21
@ti-srebot ti-srebot added this to the 3.0.20 milestone Oct 9, 2020
qw4990
qw4990 reviewed Oct 12, 2020
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 12, 2020
XuHuaiyu
XuHuaiyu reviewed Oct 27, 2020
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 27, 2020
zz-jason
zz-jason approved these changes Nov 11, 2020
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Nov 11, 2020
@zz-jason
Copy link
Member

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 11, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@bb7133
Copy link
Member

bb7133 commented Nov 11, 2020

/run-unit-test

@bb7133 bb7133 merged commit 300c11b into pingcap:release-3.0 Nov 11, 2020
@Reminiscent Reminiscent mentioned this pull request Nov 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu left review comments

@qw4990 qw4990 qw4990 left review comments

@zz-jason zz-jason zz-jason approved these changes

Assignees

@lzmhhh123 lzmhhh123

Labels
component/expression sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT3 The PR has already had 3 LGTM. type/bugfix This PR fixes a bug. type/3.0-cherry-pick
Projects
None yet
Milestone
v3.0.20
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-srebot @zz-jason @bb7133 @qw4990 @XuHuaiyu @lzmhhh123