Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: redact some error code, part(1/3) #21864

Conversation

SunRunAway
Copy link
Contributor

What problem does this PR solve?

Issue Number:

Problem Summary:
Part(1/3) of #18566 error message log redact, from ErrHashchk to ErrBinlogPurgeFatalErr.

What is changed and how it works?

What's Changed:
Add some redact parameters for these error messages.

How it Works:

Related changes

Check List

Tests

  • Unit test

Side effects

Release note

  • Error message redact normalize.

@SunRunAway
Copy link
Contributor Author

tests will be added after #20591 is merged.

@cfzjywxk
Copy link
Contributor

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 18, 2020
@bb7133
Copy link
Member

bb7133 commented Dec 18, 2020

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 18, 2020
@bb7133
Copy link
Member

bb7133 commented Dec 18, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 18, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #21889

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Dec 20, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
ti-srebot added a commit that referenced this pull request Jan 25, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/server status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants