Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: redact some error code, part(3/3) #21866

Merged
merged 6 commits into from
Dec 19, 2020
Merged

Conversation

bb7133
Copy link
Member

@bb7133 bb7133 commented Dec 17, 2020

What problem does this PR solve?

Issue Number:

Problem Summary:
Part(3/3) of #18566 error message log redact, from ErrMalformedGtidSetSpecification to ErrTiKVMaxTimestampNotSynced, as well as the TiDB-defined errors listed in https://gist.github.com/SunRunAway/49186fa488501a5b3114eaea14b17b88.

What is changed and how it works?

What's Changed:
Add some redact parameters for these error messages.

How it Works:

Related changes

Check List

Tests

  • Unit test

Side effects

Release note

  • Error message redact normalize.

@bb7133
Copy link
Member Author

bb7133 commented Dec 17, 2020

tests will be added after #20591 and #21864 is merged.

errno/errname.go Outdated Show resolved Hide resolved
errno/errname.go Outdated Show resolved Hide resolved
errno/errname.go Show resolved Hide resolved
@cfzjywxk
Copy link
Contributor

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 18, 2020
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Dec 19, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Dec 19, 2020
@SunRunAway
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 19, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 1a9852f into pingcap:master Dec 19, 2020
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Dec 20, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #21890

bb7133 added a commit to bb7133/tidb that referenced this pull request Feb 2, 2021
@bb7133 bb7133 deleted the bb7133/redact_3 branch December 29, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/server status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants