*: Implementing RENAME USER #24413

mjonss · 2021-05-05T09:51:06Z

What problem does this PR solve?

Issue Number: close #23648

Problem Summary: RENAME USER is not supported by TiDB, this PR adds support for it.

What is changed and how it works?

What's Changed: Added RENAME USER

How it Works: RENAME USER <from_user> TO <to_user> [, <from_user2> to <to_user2> [...]]
Renames one or more users ('user'@'host'). Similar code as DROP USER, to cover all internal mysql.* tables that are related.

Either the whole command succeeds or nothing is done, i.e. there will be no users that are renamed in case of error for other users. Everything is done in a single transaction, which is rolled back on error.

Related changes

PR to update pingcap/docs/pingcap/docs-cn: TODO.

Check List

Tests

Unit tests
Integration tests
Manual test (add detailed scripts or steps below)
- CREATE USER, RENAME USER only by name, both name and host, non existing.

Side effects

None.

Release note

TiDB now supports the RENAME USER statement. This helps improve compatibility with MySQL.

TODO: Add tests, check coverage and privileges including roles

CLAassistant · 2021-05-05T09:51:11Z

All committers have signed the CLA.

ti-srebot · 2021-05-05T09:51:18Z

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

ti-srebot · 2021-05-05T09:51:47Z

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

ti-srebot · 2021-05-05T12:27:09Z

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

ti-srebot · 2021-05-05T12:27:37Z

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

morgo

Looking good. Just a couple of comments.

For tests, please add:

A unit test to planbuilder which shows the visitInfo for CREATE USER attached.
Tests for renaming both a single user and multiple users, including a case where one of the renames should fail (because an existing user has the to-be-renamed name).

planner/core/planbuilder.go

executor/simple.go

And restored the temporarily removed test case (to speed up development of my patch)

Just added multi user rename, with failure on the second TO user.

TODO: Add tests, check coverage and privileges including roles

And restored the temporarily removed test case (to speed up development of my patch)

Just added multi user rename, with failure on the second TO user.

…rename_user Also removed a non-needed line in the test

No longer needed.

morgo · 2021-05-11T21:56:21Z

/LGTM

privilege/privileges/privileges_test.go

djshow832 · 2021-05-14T13:11:25Z

executor/simple.go

+			break
+		}
+
+		if err = renameUserHostInSystemTable(sqlExecutor, mysql.UserTable, "User", "Host", userToUser); err != nil {


There are 9 system tables to modify. Maybe you can put the params in an array and iterate the array to simplify the code?

I agree, and that is why I also added a comment about it.

Do you want me to add the refactoring of DROP USER and the new code in this PR or in a separate PR?

I prefer a separate PR.

executor/simple.go

Changed array of string to single string. DROP USER IF EXISTS in tests to make it more stable Changed test to use ErrorMatches to avoid code dependent errors

djshow832 · 2021-05-17T08:10:20Z

Please resolve conflicts. Rest lgtm.

djshow832 · 2021-05-19T06:31:21Z

/lgtm

ti-chi-bot · 2021-05-19T06:31:24Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

djshow832
morgo

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

djshow832 · 2021-05-19T06:32:24Z

/merge

ti-chi-bot · 2021-05-19T06:32:27Z

This pull request has been accepted and is ready to merge.

Commit hash: 739a1f4

ti-chi-bot · 2021-05-19T08:14:53Z

/run-all-tests

This bot automatically retries jobs that failed on can merge PRs (send feedback to hi-rustin).

Silence the bot with the /merge cancel comment for consistent failures.

ti-chi-bot · 2021-05-19T15:55:58Z

@mjonss: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Rustin170506 · 2021-05-19T16:08:29Z

/run-check_dev_2

…ingcap#24052) * *: fix revoke statement for CURRENT_USER() and refine error message planner: support set tidb_allow_mpp to `2` or `ENFORCE` to enforce use mpp mode. (pingcap#24516) store/tikv: remove use of SchemaAmender option in store/tikv (pingcap#24408) *: the value of tikv-client.store-liveness-timeout should not less than 0 (pingcap#24244) store/tikv: remove use of EnableAsyncCommit option in store/tikv (pingcap#24462) txn: Add txn state's view (pingcap#22908) planner: ignore lock for temporary table of PointGet and BatchPointGet (pingcap#24540) store/tikv: remove use of ReplicaRead transaction option in store/tikv (pingcap#24409) store/driver: move error to single package (pingcap#24549) ddl: add check table compatibility for temporary table (pingcap#24501) store/tikv: remove use of IsStatenessReadOnly option in store/tikv (pingcap#24464) store/tikv: change backoff type for missed tiflash peer. (pingcap#24577) store/tikv: remove use of MatchStoreLabels transaction option in store/tikv (pingcap#24465) executor, meta: Allocate auto id for global temporary tables (pingcap#24506) store/tikv: remove use of SampleStep option in store/tikv (pingcap#24461) executor: add partition pruning tests for adding and dropping partition operations (pingcap#24573) ddl: forbid partition on temporary mode before put into queue (pingcap#24565) ddl: speedup test case TestIndexOnMultipleGeneratedColumn (pingcap#24487) execution: Fix issue 24439 Inconsistent error with MySQL for GRANT CREATE USER ON <specific db>.* (pingcap#24485) *: fix errcheck (pingcap#24463) test: make TestExtractStartTs stable (pingcap#24585) ddl: forbid recover/flashback temporary tables (pingcap#24518) executor: fix point_get result on clustered index when new-row-format disabled but new-collation enabled (pingcap#24544) executor: Improve the performance of appending not fixed columns (pingcap#20969) *: typo fix (pingcap#24564) planner/core: refresh stale regions in cache for batch cop response (pingcap#24457) binlog: DML on temporary tables do not write binlog (pingcap#24570) store/tikv: remove use of GuaranteeLinearizability option in store/tikv (pingcap#24605) store/tikv: remove use of CollectRuntimeStats option in store/tikv (pingcap#24604) store/tikv: move Backoffer into a single package (pingcap#24525) variables: init cte max recursive deeps in a new session (pingcap#24609) store/tikv: move transaction options out to /kv (pingcap#24619) store/driver: move backoff driver into single package so we can use i… (pingcap#24624) server: close the temporary session in HTTP API to avoid memory leak (pingcap#24339) store/tikv: use latest PD TS plus one as min commit ts (pingcap#24579) planner: fix incorrect TableDual plan built from nulleq (pingcap#24596) ranger: fix the case which could have duplicate ranges (pingcap#24590) executor, store: Pass the SQL digest down to pessimistic lock request (pingcap#24380) kv: remove UnionStore interface (pingcap#24625) *: enable gosimple linter (pingcap#24617) txn: avoid the gc resolving pessimistic locks of ongoing transactions (pingcap#24601) util: fix wrong enum building for index range (pingcap#24632) sessionctx: change innodb large prefix default (pingcap#24555) store: fix data race about KVStore.tikvClient (pingcap#24655) executor, privileges: Add dynamic privileges to SHOW PRIVILEGES (pingcap#24646) ddl: refactor rule [4/6] (pingcap#24007) cmd: ddl_test modify retryCnt from 5 to 20 (pingcap#24662) executor: add correctness tests about direct reading with ORDER BY and LIMIT (pingcap#24455) store/tikv: remove options from unionstore (pingcap#24629) planner: fix wrongly check for update statement (pingcap#24614) store/tikv: remove CompareTS (pingcap#24657) planner, privilege: Add security enhanced mode part 4 (pingcap#24416) executor: add some test cases about partition table dynamic-mode with split-region (pingcap#24665) planner: fix wrong column offsets when processing dynamic pruning for IndexJoin (pingcap#24659) *: Add security enhanced mode part 3 (pingcap#24412) store/tikv: resolve ReplicaReadType dependencies (pingcap#24653) executor: add test cases about partition table with `expression` (pingcap#24628) tablecodec: fix write wrong prefix index value when collation is ascii_bin/latin1_bin (pingcap#24578) *: compatibility with staleread (pingcap#24285) session: test that temporary tables will also be retried (pingcap#24505) domain, session: Add new sysvarcache to replace global values cache (pingcap#24359) ddl, transaction: DDL on temporary tables won't affect transactions (pingcap#24534) *: implement tidb_bounded_staleness built-in function (pingcap#24328) executor: add correctness tests for partition table with different joins (pingcap#24673) expression: fix the spelling of word arithmetical (pingcap#24713) store/copr: balance region for batch cop task (pingcap#24521) store, metrics: Add metrics for safetTS updating (pingcap#24687) sem: add tidbredact log to restricted variables (pingcap#24701) session: fix dml_batch_size doesn't load the global variable (pingcap#24710) store/tikv: retry TSO RPC (pingcap#24682) expression, planner: push cast down to control function with enum type. (pingcap#24542) executor: add correctness tests about IndexMerge (pingcap#24674) variable: change default for DefDMLBatchSize tidbOptInt64 call (pingcap#24697) planner: add partitioning pruning tests for range partitioning (pingcap#24554) *: add option for enum push down (pingcap#24685) txn: break dependency from store/tikv to tidb/kv cause by TransactionOption (pingcap#24656) executor: enhancement for ListInDisk(support writing after reading) (pingcap#24379) kv: move TxnScope into kv (pingcap#24715) execution: fix the incorrect use of cached plan for point get (pingcap#24749) executor: add correctness tests about direct reading with indexJoin (pingcap#24497) variable: fix sysvar datarace with deep copy (pingcap#24732) *: Implementing RENAME USER (pingcap#24413) infoschema, executor: Add the deadlock table (pingcap#24524) docs: Some proposal for renaming and configurations for Lock View (pingcap#24718) planner: add range partition boundaries tests with BETWEEN expression (pingcap#24598) oracle: simplify timestamp utilities (pingcap#24688) executor: fix wrong enum key in point get (pingcap#24618) ranger: fix incorrect enum range for xxx_ci collation (pingcap#24661) executor: add some test cases about dynamic-mode and apply operator (pingcap#24683) store/tikv: remove Variables.Hook (pingcap#24758) ddl: speed up the execution time of `TestBackwardCompatibility`. (pingcap#24704) *: prepare errors for CTE (pingcap#24763) expression: support cast real/int as real (pingcap#24670) executor: add table name in log (pingcap#24666) expression: add builtin function ``json_pretty`` (pingcap#24675) ddl: make `TestDropLastVisibleColumns` stable (pingcap#24790) * ddl: make `TestDropLastVisibleColumns` stable *: support AS OF TIMESTAMP read-only begin statement (pingcap#24740) executor: Fix unstable TestTiDBLastTxnInfoCommitMode (pingcap#24779) planner: add tests for partition range boundaries for LT/GT (pingcap#24574) test: record random seed in TestIssue20658 (pingcap#24782) store/tikv/retry: define Config instead of BackoffType (pingcap#24692) config: ignore tiflash when show config (pingcap#24770) privileges: improve dynamic privs registration and tests (pingcap#24773) README: remove the link of TiDB Monthly Update (pingcap#24791) region_cache: filter peers on tombstone or dropped stores (pingcap#24726) util/stmtsummary: remove import package tikv (pingcap#24776) ddl: grammar check for create unsupported temporary table (pingcap#24723) *: update go.etcd.io/bbolt (pingcap#24799) ddl: speed up the execution time of `ddl test` and `Test Chunk pingcap#7 ddl-other` (pingcap#24780) executor: remove the unnecessary use of fmt.Sprintf (pingcap#24815) executor: fix index join panic on prefix index on some cases (pingcap#24568)

*: RENAME USER

ccc82aa

TODO: Add tests, check coverage and privileges including roles

ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 5, 2021

ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 5, 2021

github-actions bot added sig/execution SIG execution sig/sql-infra SIG: SQL Infra labels May 5, 2021

Reverted go.mod and go.sum

b8cbec7

morgo reviewed May 5, 2021

View reviewed changes

planner/core/planbuilder.go Outdated Show resolved Hide resolved

executor/simple.go Outdated Show resolved Hide resolved

mjonss added 17 commits May 6, 2021 15:13

*: fix error reporting for RENAME USER when new user exists

d320156

RENAME USER - wip issue with panic during atomic rename/swap

4bf8565

Fixed panic due to missing TimeZone in ExecuteInternal.

6f161ba

RENAME USER fixed unused variable

22017fd

And restored the temporarily removed test case (to speed up development of my patch)

RENAME USER code cleanup

06be996

RENAME USER added VisitInfo unit test

807bc86

RENAME USER, minor test case change

7e24101

Just added multi user rename, with failure on the second TO user.

*: RENAME USER

14babbd

TODO: Add tests, check coverage and privileges including roles

Reverted go.mod and go.sum

4c74304

*: fix error reporting for RENAME USER when new user exists

cd74931

RENAME USER - wip issue with panic during atomic rename/swap

f211e15

Fixed panic due to missing TimeZone in ExecuteInternal.

a8a2161

RENAME USER fixed unused variable

690bea9

And restored the temporarily removed test case (to speed up development of my patch)

RENAME USER code cleanup

5a4ccab

RENAME USER added VisitInfo unit test

0f99e3d

RENAME USER, minor test case change

f304980

Just added multi user rename, with failure on the second TO user.

Merge remote-tracking branch 'origin/mjonss/rename_user' into mjonss/…

807d6b2

…rename_user Also removed a non-needed line in the test

ti-chi-bot removed the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 10, 2021

RENAME USER, removed a temporary fix for internal decoding issue

ad610c8

No longer needed.

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 11, 2021

djshow832 reviewed May 14, 2021

View reviewed changes

privilege/privileges/privileges_test.go Outdated Show resolved Hide resolved

privilege/privileges/privileges_test.go Show resolved Hide resolved

djshow832 reviewed May 14, 2021

View reviewed changes

RENAME USER, non-logic change, adressed review comments

2b76156

Changed array of string to single string. DROP USER IF EXISTS in tests to make it more stable Changed test to use ErrorMatches to avoid code dependent errors

ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 17, 2021

Merge branch 'master' into mjonss/rename_user

739a1f4

ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 18, 2021

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 19, 2021

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 19, 2021

Merge branch 'master' into mjonss/rename_user

fafa335

ti-chi-bot added 6 commits May 19, 2021 17:42

Merge branch 'master' into mjonss/rename_user

7645dee

Merge branch 'master' into mjonss/rename_user

ab324bd

Merge branch 'master' into mjonss/rename_user

8f6d99a

Merge branch 'master' into mjonss/rename_user

1a23a18

Merge branch 'master' into mjonss/rename_user

d9f7e09

Merge branch 'master' into mjonss/rename_user

3ea44b3

ti-chi-bot merged commit 15dfd7b into pingcap:master May 19, 2021

mjonss deleted the mjonss/rename_user branch May 20, 2021 20:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

*: Implementing RENAME USER #24413

*: Implementing RENAME USER #24413

mjonss commented May 5, 2021 •

edited

Loading

CLAassistant commented May 5, 2021 •

edited

Loading

ti-srebot commented May 5, 2021

ti-srebot commented May 5, 2021

ti-srebot commented May 5, 2021

ti-srebot commented May 5, 2021

morgo left a comment

morgo commented May 11, 2021

djshow832 May 14, 2021

mjonss May 17, 2021

djshow832 May 17, 2021

djshow832 commented May 17, 2021

djshow832 commented May 19, 2021

ti-chi-bot commented May 19, 2021

djshow832 commented May 19, 2021

ti-chi-bot commented May 19, 2021

ti-chi-bot commented May 19, 2021

ti-chi-bot commented May 19, 2021

Rustin170506 commented May 19, 2021

*: Implementing RENAME USER #24413

*: Implementing RENAME USER #24413

Conversation

mjonss commented May 5, 2021 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Related changes

Check List

Release note

CLAassistant commented May 5, 2021 • edited Loading

ti-srebot commented May 5, 2021

ti-srebot commented May 5, 2021

ti-srebot commented May 5, 2021

ti-srebot commented May 5, 2021

morgo left a comment

Choose a reason for hiding this comment

morgo commented May 11, 2021

djshow832 May 14, 2021

Choose a reason for hiding this comment

mjonss May 17, 2021

Choose a reason for hiding this comment

djshow832 May 17, 2021

Choose a reason for hiding this comment

djshow832 commented May 17, 2021

djshow832 commented May 19, 2021

ti-chi-bot commented May 19, 2021

djshow832 commented May 19, 2021

ti-chi-bot commented May 19, 2021

ti-chi-bot commented May 19, 2021

ti-chi-bot commented May 19, 2021

Rustin170506 commented May 19, 2021

mjonss commented May 5, 2021 •

edited

Loading

CLAassistant commented May 5, 2021 •

edited

Loading