Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codec: Don't convert set or enum datum to float64 when encoding them #32308

Merged
merged 5 commits into from
Feb 15, 2022
Merged

codec: Don't convert set or enum datum to float64 when encoding them #32308

merged 5 commits into from
Feb 15, 2022

Conversation

ekexium
Copy link
Contributor

@ekexium ekexium commented Feb 14, 2022 •
edited
Loading

Signed-off-by: ekexium ekexium@gmail.com

What problem does this PR solve?

Issue Number: close #32302

Problem Summary:

When a enum or a set datum is encoded, it's uint64 value is converted to float64 and then converted back to uint64, resulting in the loss of lower bits.

What is changed and how it works?

Use the original Value, don't convert.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ekexium
don't convert set or enum datum to float64 when encoding them
7002c6b 
Signed-off-by: ekexium <ekexium@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 14, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • MyonKeminta
  • cfzjywxk

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-cherry-pick-4.0 needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. and removed do-not-merge/needs-triage-completed labels Feb 14, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Feb 14, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/4d9cc43d071f05a495d71a4818bf771ffe53f278

@ekexium
Copy link
Contributor Author

ekexium commented Feb 14, 2022

/run-all-tests

@cfzjywxk cfzjywxk added the sig/execution SIG execution label Feb 14, 2022
@ekexium
tidy up
06e1154 
Signed-off-by: ekexium <ekexium@gmail.com>
cfzjywxk
cfzjywxk reviewed Feb 14, 2022
View reviewed changes
executor/executor_test.go
func (s *testSerialSuite) TestEncodingSet(c *C) {
tk := testkit.NewTestKit(c, s.store)
tk.MustExec("use test")
tk.MustExec("CREATE TABLE `enum-set` (`set` SET(" +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could cover KindMysqlEnum in the same case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's hard to cover enum in the test. I don't even know whether the bug exist for enum, because MySQL limits the maximum number of elements of a enum at 65535. I guess it's not large enough to produce a precision loss.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 15, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 15, 2022
@cfzjywxk
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 06e1154

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 15, 2022
@ti-chi-bot ti-chi-bot merged commit 886650b into pingcap:master Feb 15, 2022
@ti-srebot ti-srebot mentioned this pull request Feb 15, 2022
Closed
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 15, 2022
@ekexium @ti-srebot
cherry pick pingcap#32308 to release-4.0
0b0bf0c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #32350

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 15, 2022
@ekexium @ti-srebot
cherry pick pingcap#32308 to release-5.0
1df538b 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Feb 15, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #32351

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 15, 2022
@ekexium @ti-srebot
cherry pick pingcap#32308 to release-5.1
eaedbb1 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Feb 15, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #32352

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 15, 2022
@ekexium @ti-srebot
cherry pick pingcap#32308 to release-5.2
7c7b2a6 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Feb 15, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #32353

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 15, 2022
@ekexium @ti-srebot
cherry pick pingcap#32308 to release-5.3
f4c093e 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Feb 15, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #32354

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 15, 2022
@ekexium @ti-srebot
cherry pick pingcap#32308 to release-5.4
e34e9e4 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Feb 15, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #32355

@ekexium ekexium mentioned this pull request Feb 15, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this pull request Feb 22, 2022
@ti-srebot
codec: Don't convert set or enum datum to float64 when encoding them (#…
a17f90a 
…32308) (#32354)

close #32302
This was referenced Feb 23, 2022
Closed
Closed
Closed
Closed
Closed
Closed
ti-chi-bot pushed a commit that referenced this pull request Apr 13, 2022
@ti-srebot
codec: Don't convert set or enum datum to float64 when encoding them (#…
7533a6b 
…32308) (#32353)

close #32302
ti-chi-bot pushed a commit that referenced this pull request Apr 29, 2022
@ti-srebot
codec: Don't convert set or enum datum to float64 when encoding them (#…
cf3591f 
…32308) (#32355)

close #32302
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MyonKeminta MyonKeminta MyonKeminta approved these changes

@cfzjywxk cfzjywxk cfzjywxk approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note-none Denotes a PR that doesn't merit a release note. sig/execution SIG execution size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using set as primary key results in inconsistent index
6 participants
@ekexium @ti-chi-bot @sre-bot @cfzjywxk @ti-srebot @MyonKeminta