Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codec: Don't convert set or enum datum to float64 when encoding them (#32308) #32353

Merged
merged 9 commits into from
Apr 13, 2022
Merged

codec: Don't convert set or enum datum to float64 when encoding them (#32308) #32353

merged 9 commits into from
Apr 13, 2022

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Feb 15, 2022 •
edited
Loading

cherry-pick #32308 to release-5.2
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/32353

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/32353:release-5.2-886650b58265

Signed-off-by: ekexium ekexium@gmail.com

What problem does this PR solve?

Issue Number: close #32302

Problem Summary:

When a enum or a set datum is encoded, it's uint64 value is converted to float64 and then converted back to uint64, resulting in the loss of lower bits.

What is changed and how it works?

Use the original Value, don't convert.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ekexium @ti-srebot
cherry pick pingcap#32308 to release-5.2
7c7b2a6 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 15, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • MyonKeminta
  • cfzjywxk

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 15, 2022
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 15, 2022
@ti-srebot ti-srebot added sig/execution SIG execution size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/5.2-cherry-pick labels Feb 15, 2022
@ti-srebot ti-srebot mentioned this pull request Feb 15, 2022
Merged
12 tasks
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 15, 2022
@ekexium
fix conflict
4577202 
Signed-off-by: ekexium <ekexium@gmail.com>
@ekexium ekexium force-pushed the release-5.2-886650b58265 branch from b602510 to 4577202 Compare February 16, 2022 06:19
@ekexium
Copy link
Contributor

ekexium commented Feb 16, 2022

/run-check_dev

1 similar comment
@ekexium
Copy link
Contributor

ekexium commented Feb 17, 2022

/run-check_dev

@ekexium
cherry pick
c8a7f71 
Signed-off-by: ekexium <ekexium@gmail.com>
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 24, 2022
@ekexium ekexium mentioned this pull request Feb 24, 2022
Closed
12 tasks
@ekexium
Copy link
Contributor

ekexium commented Feb 28, 2022

/run-check_dev

1 similar comment
@ekexium
Copy link
Contributor

ekexium commented Feb 28, 2022

/run-check_dev

@ekexium
Copy link
Contributor

ekexium commented Apr 11, 2022

/run-check_dev

@ekexium
Copy link
Contributor

ekexium commented Apr 11, 2022

PTAL @cfzjywxk @MyonKeminta

@purelind
Copy link
Contributor

/run-unit-test
/run-mysql-test

@purelind
Copy link
Contributor

/run-build

@purelind
Copy link
Contributor

/run-check_dev2

@purelind
Copy link
Contributor

/run-check_dev_2

@purelind
Copy link
Contributor

/run-all-tests

@purelind
Copy link
Contributor

/run-unit-test

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 11, 2022
@ekexium
Copy link
Contributor

ekexium commented Apr 11, 2022

/run-check_dev

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 12, 2022
@ekexium
Copy link
Contributor

ekexium commented Apr 12, 2022

/run-unit-test

1 similar comment
@ekexium
Copy link
Contributor

ekexium commented Apr 12, 2022

/run-unit-test

@sre-bot
Copy link
Contributor

sre-bot commented Apr 12, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/2a274885c588aa6870892deed56b0105b5cb2069

@winoros
Copy link
Member

winoros commented Apr 12, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c8a7f71

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 12, 2022
@hawkingrei
Copy link
Member

/run-mysql-test

@hawkingrei
Copy link
Member

/run-mysql-test

@ti-chi-bot ti-chi-bot merged commit 7533a6b into pingcap:release-5.2 Apr 13, 2022
@zhouqiang-cl zhouqiang-cl added this to the v5.2.4 milestone Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MyonKeminta MyonKeminta MyonKeminta approved these changes

@cfzjywxk cfzjywxk cfzjywxk approved these changes

Assignees

@ekexium ekexium

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. sig/execution SIG execution size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.2-cherry-pick
Projects
None yet
Milestone
v5.2.4
Development

Successfully merging this pull request may close these issues.