Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(parser): restore table option INSERT_METHOD should use WriteKeyWord #38355

Merged
merged 5 commits into from
Oct 10, 2022
Merged

fix(parser): restore table option INSERT_METHOD should use WriteKeyWord #38355

merged 5 commits into from
Oct 10, 2022

Conversation

h3n4l
Copy link
Contributor

@h3n4l h3n4l commented Oct 10, 2022 •
edited by xhebox
Loading

What problem does this PR solve?

Problem Summary:
Issue Number: close #38368
Restore table option INSERT_METHOD should always be without quotes.
CleanShot 2022-10-10 at 14 12 25@2x

What is changed and how it works?

Use WriteKeyWord() instead of WriteString(), both upper case and lower case can works well.
CleanShot 2022-10-10 at 14 13 18@2x

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 10, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 10, 2022
@h3n4l
Copy link
Contributor Author

h3n4l commented Oct 10, 2022

/cc @JmPotato

@ti-chi-bot ti-chi-bot requested a review from JmPotato October 10, 2022 06:14
@h3n4l h3n4l changed the title fix: restore table option INSERT_METHOD should use WriteKeyWord fix(parser): restore table option INSERT_METHOD should use WriteKeyWord Oct 10, 2022
JmPotato
JmPotato reviewed Oct 10, 2022
View reviewed changes
Copy link
Member

@JmPotato JmPotato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM.

parser/parser_test.go Outdated Show resolved Hide resolved
@h3n4l @JmPotato
Update parser/parser_test.go
19be56a 
Co-authored-by: JmPotato <github@ipotato.me>
@h3n4l h3n4l requested a review from JmPotato October 10, 2022 07:42
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 10, 2022
@JmPotato
Copy link
Member

/cc @bb7133 @xhebox

@ti-chi-bot ti-chi-bot requested review from bb7133 and xhebox October 10, 2022 07:44
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 10, 2022
@xhebox xhebox added the type/bugfix This PR fixes a bug. label Oct 10, 2022
@xhebox
Copy link
Contributor

xhebox commented Oct 10, 2022

@h3n4l Please open a corresponding bug issue. I'll merge this PR after that.

@xhebox
Copy link
Contributor

xhebox commented Oct 10, 2022

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2022
@h3n4l h3n4l mentioned this pull request Oct 10, 2022
Closed
@h3n4l
Copy link
Contributor Author

h3n4l commented Oct 10, 2022

@h3n4l Please open a corresponding bug issue. I'll merge this PR after that.

Hey @xhebox , I submit an issue #38368 related to this bug.

@xhebox
Copy link
Contributor

xhebox commented Oct 10, 2022

/check-issue-triage-complete
/merge

@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 and removed do-not-merge/needs-triage-completed labels Oct 10, 2022
@ti-chi-bot
Copy link
Member

@xhebox: new pull request could not be created: failed to create pull request against pingcap/tidb#release-6.3 from head ti-chi-bot:cherry-pick-38355-to-release-6.3: the GitHub API request returns a 403 error: {"message":"You have exceeded a secondary rate limit and have been temporarily blocked from content creation. Please retry your request again later.","documentation_url":"https://docs.github.com/rest/overview/resources-in-the-rest-api#secondary-rate-limits"}

In response to this:

/cherry-pick release-6.3
/cherry-pick release-6.1
/cherry-pick release-5.4
/cherry-pick release-5.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@xhebox
Copy link
Contributor

xhebox commented Oct 11, 2022

/cherry-pick release-6.3
/cherry-pick release-6.1
/cherry-pick release-5.4
/cherry-pick release-5.3

@ti-chi-bot
Copy link
Member

@xhebox: new pull request could not be created: failed to create pull request against pingcap/tidb#release-5.3 from head ti-chi-bot:cherry-pick-38355-to-release-5.3: the GitHub API request returns a 403 error: {"message":"You have exceeded a secondary rate limit and have been temporarily blocked from content creation. Please retry your request again later.","documentation_url":"https://docs.github.com/rest/overview/resources-in-the-rest-api#secondary-rate-limits"}

In response to this:

/cherry-pick release-6.3
/cherry-pick release-6.1
/cherry-pick release-5.4
/cherry-pick release-5.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@xhebox: new pull request could not be created: failed to create pull request against pingcap/tidb#release-5.4 from head ti-chi-bot:cherry-pick-38355-to-release-5.4: the GitHub API request returns a 403 error: {"message":"You have exceeded a secondary rate limit and have been temporarily blocked from content creation. Please retry your request again later.","documentation_url":"https://docs.github.com/rest/overview/resources-in-the-rest-api#secondary-rate-limits"}

In response to this:

/cherry-pick release-6.3
/cherry-pick release-6.1
/cherry-pick release-5.4
/cherry-pick release-5.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@xhebox: new pull request could not be created: failed to create pull request against pingcap/tidb#release-6.1 from head ti-chi-bot:cherry-pick-38355-to-release-6.1: the GitHub API request returns a 403 error: {"message":"You have exceeded a secondary rate limit and have been temporarily blocked from content creation. Please retry your request again later.","documentation_url":"https://docs.github.com/rest/overview/resources-in-the-rest-api#secondary-rate-limits"}

In response to this:

/cherry-pick release-6.3
/cherry-pick release-6.1
/cherry-pick release-5.4
/cherry-pick release-5.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@xhebox: new pull request could not be created: failed to create pull request against pingcap/tidb#release-6.3 from head ti-chi-bot:cherry-pick-38355-to-release-6.3: the GitHub API request returns a 403 error: {"message":"You have exceeded a secondary rate limit and have been temporarily blocked from content creation. Please retry your request again later.","documentation_url":"https://docs.github.com/rest/overview/resources-in-the-rest-api#secondary-rate-limits"}

In response to this:

/cherry-pick release-6.3
/cherry-pick release-6.1
/cherry-pick release-5.4
/cherry-pick release-5.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@xhebox
Copy link
Contributor

xhebox commented Oct 11, 2022

/cherry-pick release-6.3

@xhebox
Copy link
Contributor

xhebox commented Oct 11, 2022

/cherry-pick release-6.1

@xhebox
Copy link
Contributor

xhebox commented Oct 11, 2022

/cherry-pick release-5.4

@xhebox
Copy link
Contributor

xhebox commented Oct 11, 2022

/cherry-pick release-5.3

@ti-chi-bot
Copy link
Member

@xhebox: new pull request created: #38393.

In response to this:

/cherry-pick release-6.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 11, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

@xhebox: new pull request created: #38394.

In response to this:

/cherry-pick release-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 11, 2022
@h3n4l @ti-chi-bot
fix(parser): restore table option INSERT_METHOD should use WriteKeyWo…
a905149 
…rd (pingcap#38355)

close pingcap#38368
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 11, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

@xhebox: new pull request created: #38395.

In response to this:

/cherry-pick release-5.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 11, 2022
Merged
12 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 11, 2022
@h3n4l @ti-chi-bot
fix(parser): restore table option INSERT_METHOD should use WriteKeyWo…
45223e2 
…rd (pingcap#38355)

close pingcap#38368
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 11, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

@xhebox: new pull request created: #38396.

In response to this:

/cherry-pick release-5.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 11, 2022
@h3n4l @ti-chi-bot
fix(parser): restore table option INSERT_METHOD should use WriteKeyWo…
c780f97 
…rd (pingcap#38355)

close pingcap#38368
ti-chi-bot added a commit that referenced this pull request Oct 12, 2022
@ti-chi-bot
fix(parser): restore table option INSERT_METHOD should use WriteKeyWo…
b2ae5e6 
…rd (#38355) (#38396)

close #38368
ti-chi-bot added a commit that referenced this pull request Oct 12, 2022
@ti-chi-bot
fix(parser): restore table option INSERT_METHOD should use WriteKeyWo…
df3e644 
…rd (#38355) (#38394)

close #38368
ti-chi-bot added a commit that referenced this pull request Oct 14, 2022
@ti-chi-bot
fix(parser): restore table option INSERT_METHOD should use WriteKeyWo…
1acd0b6 
…rd (#38355) (#38395)

close #38368
h3n4l added a commit to bytebase/tidb that referenced this pull request Oct 26, 2022
@h3n4l
fix(parser): restore table option INSERT_METHOD should use WriteKeyWo…
78517e0 
…rd (pingcap#38355)

close pingcap#38368
ti-chi-bot added a commit that referenced this pull request Nov 4, 2022
@ti-chi-bot
fix(parser): restore table option INSERT_METHOD should use WriteKeyWo…
113e2cc 
…rd (#38355) (#38393)

close #38368
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox approved these changes

@JmPotato JmPotato JmPotato approved these changes

@bb7133 bb7133 Awaiting requested review from bb7133

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

parser: table option should always restore without quotes
5 participants
@h3n4l @ti-chi-bot @JmPotato @xhebox @sre-bot