-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(parser): restore table option INSERT_METHOD should use WriteKeyWord (#38355) #38393
fix(parser): restore table option INSERT_METHOD should use WriteKeyWord (#38355) #38393
Conversation
Co-authored-by: JmPotato <github@ipotato.me>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
c8bcfb5
to
c7951ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @JmPotato
/merge |
This pull request has been accepted and is ready to merge. Commit hash: c7951ef
|
/run-unit-test |
This is an automated cherry-pick of #38355
What problem does this PR solve?
Problem Summary:
Issue Number: close #38368
Restore table option
INSERT_METHOD
should always be without quotes.What is changed and how it works?
Use
WriteKeyWord()
instead ofWriteString()
, both upper case and lower case can works well.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.