Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix plan cache rebuild range error #42220

Merged
merged 6 commits into from
Mar 17, 2023
Merged

planner: fix plan cache rebuild range error #42220

merged 6 commits into from
Mar 17, 2023

Conversation

fzzf678
Copy link
Contributor

@fzzf678 fzzf678 commented Mar 14, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #42150

Problem Summary:
When rebuild range for IndexFullScan, if there is no filter on columns, the type slice may out of bound. There should be early stop logic facing this situation.

What is changed and how it works?

Return full range when build index full scan without filter cols

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 14, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • xuyifangreeneyes

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 14, 2023
@fzzf678 fzzf678 marked this pull request as ready for review March 14, 2023 12:13
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 14, 2023
@fzzf678
Copy link
Contributor Author

fzzf678 commented Mar 15, 2023

/retest

3 similar comments
@fzzf678
Copy link
Contributor Author

fzzf678 commented Mar 15, 2023

/retest

@fzzf678
Copy link
Contributor Author

fzzf678 commented Mar 15, 2023

/retest

@fzzf678
Copy link
Contributor Author

fzzf678 commented Mar 15, 2023

/retest

qw4990
qw4990 reviewed Mar 15, 2023
View reviewed changes
planner/core/plan_cache.go Outdated
@@ -662,6 +662,10 @@ func buildRangeForTableScan(sctx sessionctx.Context, ts *PhysicalTableScan) (err
}

func buildRangeForIndexScan(sctx sessionctx.Context, is *PhysicalIndexScan) (err error) {
if len(is.IdxCols) == 0 { // return full range when PhysicalIndexScan has no IdxCols
is.Ranges = ranger.FullRange()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

if IsFullRagne(is.Ranges) { // the original range is already a full-range.
    return nil
} else {
    return error("unexpected")
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qw4990 Do you mean that we should assert IsFullRagne(is.Ranges) must stand when len(is.IdxCols) == 0?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'm not sure whether len(is.IdxCols)==0 can guarantee this is a IndexFullScan, so check IsFullRagne(is.Ranges) for safety.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it

@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 15, 2023
@fzzf678
Copy link
Contributor Author

fzzf678 commented Mar 15, 2023

@qw4990 @xuyifangreeneyes updated, TPAL again

@fzzf678 fzzf678 requested a review from winoros March 16, 2023 08:48
@fzzf678 fzzf678 added the type/bugfix This PR fixes a bug. label Mar 17, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 17, 2023
@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Mar 17, 2023
@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Mar 17, 2023
@winoros
Copy link
Member

winoros commented Mar 17, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 67cc542

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 17, 2023
@ti-chi-bot ti-chi-bot merged commit 71ce68c into pingcap:master Mar 17, 2023
@fzzf678 fzzf678 added needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. labels Mar 20, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 20, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.4: #42380.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 20, 2023
@fzzf678 @ti-chi-bot
This is an automated cherry-pick of pingcap#42220
d027e96 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 20, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #42381.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 20, 2023
@fzzf678 @ti-chi-bot
This is an automated cherry-pick of pingcap#42220
6b56750 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 20, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #42382.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 20, 2023
@fzzf678 @ti-chi-bot
This is an automated cherry-pick of pingcap#42220
cf79994 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@fzzf678
Copy link
Contributor Author

fzzf678 commented Mar 20, 2023 •
edited
Loading

this bug won't affect 5.4 6.1 6.5, but we need cherry-pick a test to these version just for sure

ti-chi-bot added a commit that referenced this pull request Mar 20, 2023
@ti-chi-bot
planner: fix plan cache rebuild range error (#42220) (#42380)
af1aba6 
close #42150
ti-chi-bot added a commit that referenced this pull request Mar 20, 2023
@ti-chi-bot
planner: fix plan cache rebuild range error (#42220) (#42382)
66f0df7 
close #42150
ti-chi-bot added a commit that referenced this pull request Mar 21, 2023
@ti-chi-bot
planner: fix plan cache rebuild range error (#42220) (#42381)
e4e3678 
close #42150
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuyifangreeneyes xuyifangreeneyes xuyifangreeneyes approved these changes

@qw4990 qw4990 qw4990 approved these changes

@winoros winoros Awaiting requested review from winoros

Assignees
No one assigned
Labels
epic/plan-cache needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

runtime error: index out of range [0] with length 0
5 participants
@fzzf678 @ti-chi-bot @winoros @qw4990 @xuyifangreeneyes