planner: Move the Selectivity function from the stats package into cardinality package #46359

qw4990 · 2023-08-23T10:03:01Z

What problem does this PR solve?

Issue Number: ref #46358

Problem Summary: Move the Selectivity function from the stats package into cardinality package

What is changed and how it works?

No logical change, just some code movement.

Move the Selectivity function from the stats package.

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

tiprow · 2023-08-23T10:03:27Z

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hawkingrei · 2023-08-23T10:25:10Z

planner/cardinality/pseudo.go

+			}
+		case ast.GE, ast.GT, ast.LE, ast.LT:
+			minFactor = math.Min(minFactor, 1.0/pseudoLessRate)
+			// FIXME: To resolve the between case.


This FIXME was created in 2017.

OK... Let's fix it later on...

codecov · 2023-08-23T10:33:09Z

Codecov Report

Merging #46359 (0f8b47a) into master (2b766b4) will decrease coverage by 0.6274%.
Report is 2 commits behind head on master.
The diff coverage is 81.9887%.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #46359        +/-   ##
================================================
- Coverage   73.3881%   72.7607%   -0.6274%     
================================================
  Files          1288       1311        +23     
  Lines        393542     399915      +6373     
================================================
+ Hits         288813     290981      +2168     
- Misses        86351      90492      +4141     
- Partials      18378      18442        +64

Flag	Coverage Δ
integration	`25.6850% <62.6641%> (?)`
unit	`73.4393% <81.9887%> (+0.0512%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`54.0444% <ø> (ø)`
parser	`85.0741% <ø> (ø)`
br	`47.9544% <ø> (-4.3283%)`	⬇️

Rustin170506 · 2023-08-23T10:46:01Z

/cc

ti-chi-bot · 2023-08-23T13:52:38Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [hawkingrei,time-and-fate]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2023-08-23T13:52:44Z

[LGTM Timeline notifier]

Timeline:

2023-08-23 10:19:44.643127566 +0000 UTC m=+1317549.192143551: ☑️ agreed by hawkingrei.
2023-08-23 13:52:43.972831197 +0000 UTC m=+1330328.521847183: ☑️ agreed by time-and-fate.

tiprow · 2023-08-23T14:06:08Z

@qw4990: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
tiprow_fast_test	`0f8b47a`	link	true	`/test tiprow_fast_test`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

qw4990 · 2023-08-23T14:22:42Z

/test tiprow_fast_test

ti-chi-bot · 2023-08-23T14:22:46Z

@qw4990: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build
/test canary-scan-security
/test check-dev
/test check-dev2
/test mysql-test
/test pingcap/tidb/canary_ghpr_unit_test
/test pull-br-integration-test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-ddl-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-mysql-connector-test
/test pull-sqllogic-test
/test pull-tiflash-test
/test unit-test

The following commands are available to trigger optional jobs:

/test pull-notify-when-compatibility-sections-changed

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test

In response to this:

/test tiprow_fast_test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow · 2023-08-23T14:23:12Z

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test tiprow_fast_test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

qw4990 · 2023-08-23T14:25:19Z

/test tiprow_fast_test

ti-chi-bot · 2023-08-23T14:25:22Z

@qw4990: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build
/test canary-scan-security
/test check-dev
/test check-dev2
/test mysql-test
/test pingcap/tidb/canary_ghpr_unit_test
/test pull-br-integration-test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-ddl-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-mysql-connector-test
/test pull-sqllogic-test
/test pull-tiflash-test
/test unit-test

The following commands are available to trigger optional jobs:

/test pull-notify-when-compatibility-sections-changed

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test

In response to this:

/test tiprow_fast_test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow · 2023-08-23T14:25:50Z

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test tiprow_fast_test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

qw4990 · 2023-08-23T14:27:07Z

/ok-to-test

qw4990 · 2023-08-23T14:27:31Z

/test tiprow_fast_test

ti-chi-bot · 2023-08-23T14:28:03Z

@qw4990: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build
/test canary-scan-security
/test check-dev
/test check-dev2
/test mysql-test
/test pingcap/tidb/canary_ghpr_unit_test
/test pull-br-integration-test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-ddl-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-mysql-connector-test
/test pull-sqllogic-test
/test pull-tiflash-test
/test unit-test

The following commands are available to trigger optional jobs:

/test pull-notify-when-compatibility-sections-changed

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test

In response to this:

/test tiprow_fast_test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 23, 2023

fixup

c4aee96

qw4990 force-pushed the ce-decoupling branch from f945f7f to c4aee96 Compare August 23, 2023 10:11

qw4990 added sig/planner SIG: Planner epic/cardinality-estimation the optimizer cardinality estimation labels Aug 23, 2023

make linter happy

c755793

hawkingrei approved these changes Aug 23, 2023

View reviewed changes

ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 23, 2023

hawkingrei reviewed Aug 23, 2023

View reviewed changes

qw4990 added 2 commits August 23, 2023 18:34

make linter happy

a667e43

make linter happy

805054a

ti-chi-bot bot requested a review from Rustin170506 August 23, 2023 10:46

qw4990 added 8 commits August 23, 2023 19:14

make linter happy

2859078

make linter happy

baf8652

make linter happy

d6c0650

Merge remote-tracking branch 'upstream/master' into ce-decoupling

e01c5c0

fixup

bfc6461

fixup

65be71d

fixup

9a44dc4

fixup

0f8b47a

time-and-fate approved these changes Aug 23, 2023

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 23, 2023

ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Aug 23, 2023

ti-chi-bot bot merged commit 2aa82f5 into pingcap:master Aug 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

planner: Move the Selectivity function from the stats package into cardinality package #46359

planner: Move the Selectivity function from the stats package into cardinality package #46359

qw4990 commented Aug 23, 2023 •

edited

Loading

tiprow bot commented Aug 23, 2023

hawkingrei Aug 23, 2023

qw4990 Aug 23, 2023

codecov bot commented Aug 23, 2023 •

edited

Loading

Rustin170506 commented Aug 23, 2023

ti-chi-bot bot commented Aug 23, 2023

ti-chi-bot bot commented Aug 23, 2023

tiprow bot commented Aug 23, 2023

qw4990 commented Aug 23, 2023

ti-chi-bot bot commented Aug 23, 2023

tiprow bot commented Aug 23, 2023

qw4990 commented Aug 23, 2023

ti-chi-bot bot commented Aug 23, 2023

tiprow bot commented Aug 23, 2023

qw4990 commented Aug 23, 2023

qw4990 commented Aug 23, 2023

ti-chi-bot bot commented Aug 23, 2023

planner: Move the Selectivity function from the stats package into cardinality package #46359

planner: Move the Selectivity function from the stats package into cardinality package #46359

Conversation

qw4990 commented Aug 23, 2023 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

tiprow bot commented Aug 23, 2023

hawkingrei Aug 23, 2023

Choose a reason for hiding this comment

qw4990 Aug 23, 2023

Choose a reason for hiding this comment

codecov bot commented Aug 23, 2023 • edited Loading

Codecov Report

Rustin170506 commented Aug 23, 2023

ti-chi-bot bot commented Aug 23, 2023

ti-chi-bot bot commented Aug 23, 2023

[LGTM Timeline notifier]

tiprow bot commented Aug 23, 2023

qw4990 commented Aug 23, 2023

ti-chi-bot bot commented Aug 23, 2023

tiprow bot commented Aug 23, 2023

qw4990 commented Aug 23, 2023

ti-chi-bot bot commented Aug 23, 2023

tiprow bot commented Aug 23, 2023

qw4990 commented Aug 23, 2023

qw4990 commented Aug 23, 2023

ti-chi-bot bot commented Aug 23, 2023

qw4990 commented Aug 23, 2023 •

edited

Loading

codecov bot commented Aug 23, 2023 •

edited

Loading