Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: move some estimation functions from the physical-optimization package into cardinality package #46479

Merged
merged 8 commits into from
Aug 29, 2023

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Aug 29, 2023

What problem does this PR solve?

Issue Number: ref #46358

Problem Summary: Move the Selectivity function from the stats package into cardinality package

What is changed and how it works?

No logical change, just some code movement.

Follow with #46359

Move the Selectivity function from the stats package.

image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 29, 2023
@qw4990 qw4990 added sig/planner SIG: Planner epic/cardinality-estimation the optimizer cardinality estimation and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 29, 2023
@tiprow
Copy link

tiprow bot commented Aug 29, 2023

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 29, 2023
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #46479 (7bba4a2) into master (c94b9ae) will decrease coverage by 0.6709%.
Report is 2 commits behind head on master.
The diff coverage is 92.0529%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #46479        +/-   ##
================================================
- Coverage   73.3709%   72.7000%   -0.6709%     
================================================
  Files          1302       1324        +22     
  Lines        394467     400722      +6255     
================================================
+ Hits         289424     291325      +1901     
- Misses        86645      90932      +4287     
- Partials      18398      18465        +67     
Flag Coverage Δ
integration 25.6236% <77.4834%> (?)
unit 73.3770% <91.3907%> (+0.0061%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0638% <ø> (ø)
br 48.0129% <ø> (-4.3671%) ⬇️

@qw4990
Copy link
Contributor Author

qw4990 commented Aug 29, 2023

/test build

@tiprow
Copy link

tiprow bot commented Aug 29, 2023

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 29, 2023
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 29, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,time-and-fate]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 29, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 29, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-29 11:08:33.386902406 +0000 UTC m=+1838877.935918378: ☑️ agreed by time-and-fate.
  • 2023-08-29 12:55:04.924152315 +0000 UTC m=+1845269.473168286: ☑️ agreed by hawkingrei.

@ti-chi-bot ti-chi-bot bot merged commit 2db93cd into pingcap:master Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved epic/cardinality-estimation the optimizer cardinality estimation lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants