*: use AllSchemaNames to replace AllSchemas #51436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
do-not-merge/needs-tests-checked
release-note-none
ti-chi-bot
bot
removed
do-not-merge/needs-linked-issue
do-not-merge/needs-tests-checked
labels
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51436 +/- ##
================================================
+ Coverage 72.5069% 72.8133% +0.3064%
================================================
Files 1464 1464
Lines 362691 436442 +73751
================================================
+ Hits 262976 317788 +54812
- Misses 80359 98693 +18334
- Partials 19356 19961 +605
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/retest |
tiancaiamao
reviewed
Mar 1, 2024
pkg/infoschema/infoschema.go
Outdated
| @@ -43,6 +43,7 @@ type InfoSchema interface { | |||
| SchemaByID(id int64) (*model.DBInfo, bool) | |||
| TableByID(id int64) (table.Table, bool) | |||
| AllSchemas() []*model.DBInfo | |||
There was a problem hiding this comment.
Can we remove this API now?
There was a problem hiding this comment.
Still have some usages. I will remove them after this PR.
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
tiancaiamao
reviewed
Mar 1, 2024
ywqzzy
reviewed
Mar 4, 2024
ywqzzy
approved these changes
Mar 4, 2024
tiancaiamao
approved these changes
Mar 4, 2024
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
3pointer
approved these changes
Mar 4, 2024
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, easonn7, tiancaiamao, ywqzzy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #50959
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.