ddl: init global vars from system tables before start domain

[D3Hunter]

What problem does this PR solve?

Issue Number: close #54868, close #54860

Problem Summary:

What changed and how does it work?

as title, see this for root cause #54868 (comment)

Check List

Tests

• Unit test, only fix existing ones, should cover it
• Integration test
• Manual test (add detailed scripts or steps below)

bootstrap with TiKV, test some ddl/dml, they should work and check no error logs.
bootstrap with unistore, same test as above.

• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

Attention: Patch coverage is 75.60976% with 10 lines in your changes missing coverage. Please review.

Project coverage is 74.8315%. Comparing base (ee64347) to head (0006970).
Report is 23 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #54913        +/-   ##
================================================
+ Coverage   72.6924%   74.8315%   +2.1390%     
================================================
  Files          1557       1565         +8     
  Lines        438381     446555      +8174     
================================================
+ Hits         318670     334164     +15494     
+ Misses       100054      92119      -7935     
- Partials      19657      20272       +615     

Flag	Coverage Δ
integration	48.9470% <75.6097%> (?)
unit	72.0276% <65.8536%> (+0.3426%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9567% <ø> (-0.0089%)	⬇️
parser	∅ <ø> (∅)
br	52.2433% <ø> (+6.3524%)	⬆️

[D3Hunter]

/retest

[tiprow]

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[D3Hunter]

/retest

[tiprow]

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[D3Hunter]

/retest

[tiprow]

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[D3Hunter]

/retest

[tiprow]

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[D3Hunter]

/retest

[tiprow]

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[lcwangchao]

Could you also fix the print message here?

tidb/pkg/expression/context/context.go

Lines 232 to 234 in 7cdf918

	intest.Assert(ctxLocStr == varsLocStr && ctxLocStr == stmtLocStr,
	"location mismatch, ctxLoc: %s, varsLoc: %s, stmtLoc: %s",
	ctxLoc.String(), ctxLocStr, stmtLocStr,

to

 intest.Assert(ctxLocStr == varsLocStr && ctxLocStr == stmtLocStr, 
 	"location mismatch, ctxLoc: %s, varsLoc: %s, stmtLoc: %s", 
- 	ctxLoc.String(), ctxLocStr, stmtLocStr, 
+ 	ctxLocStr, varsLocStr, stmtLocStr,

[lcwangchao]

How about renaming it to StartBackgroundLoops and adding some comments that some SQL can still be executed before domain started.

[D3Hunter]

0006970

i think Start is clear enough

[YangKeao]

Also, close #54860

[YangKeao]

LGTM

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-07-29 02:41:35.492218757 +0000 UTC m=+150811.772266828: ☑️ agreed by lcwangchao.
• 2024-07-29 06:20:14.226369387 +0000 UTC m=+163930.506417453: ☑️ agreed by YangKeao.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcwangchao, wjhuang2016, YangKeao, zanmato1984

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [YangKeao,lcwangchao,wjhuang2016,zanmato1984]
• pkg/domain/OWNERS [wjhuang2016]
• pkg/expression/OWNERS [zanmato1984]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment