Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: fix br domain start #55038

Merged
merged 3 commits into from
Jul 30, 2024
Merged

br: fix br domain start #55038

merged 3 commits into from
Jul 30, 2024

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented Jul 30, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #55039

Problem Summary:

What changed and how does it work?

after #54913, we separate domain Init and Start. BR also depends on domain and should start it to do DDLs

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 30, 2024
@tiprow tiprow
Copy link

tiprow bot commented Jul 30, 2024

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@D3Hunter
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Jul 30, 2024

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov Codecov
Copy link

codecov bot commented Jul 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 76.92308% with 6 lines in your changes missing coverage. Please review.

Project coverage is 75.2570%. Comparing base (60c7e61) to head (02cf83f).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #55038        +/-   ##
================================================
+ Coverage   72.5721%   75.2570%   +2.6849%     
================================================
  Files          1565       1565                
  Lines        440227     440347       +120     
================================================
+ Hits         319482     331392     +11910     
+ Misses       100930      88321     -12609     
- Partials      19815      20634       +819
Flag Coverage Δ
integration 50.7469% <76.9230%> (?)
unit 71.6636% <73.0769%> (+0.0461%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 62.3299% <76.9230%> (+16.4809%) ⬆️

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Jul 30, 2024 •
edited
Loading

/retest

@BornChanger br integration test timeout.

@tiprow tiprow
Copy link

tiprow bot commented Jul 30, 2024

@wuhuizuo: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

@BornChanger br integration test timeouted.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

lance6716
lance6716 previously approved these changes Jul 30, 2024
View reviewed changes
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 30, 2024
@D3Hunter D3Hunter dismissed lance6716’s stale review July 30, 2024 07:26

code changed

BornChanger
BornChanger reviewed Jul 30, 2024
View reviewed changes
br/pkg/gluetidb/glue_test.go
g := Glue{}
session, err := g.CreateSession(store)
// we want to test glue start domain explicitly, so close it first.
dom.Close()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there case covering the case where dom is opened already?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check glue.GetDomain, it will get session twice, domain has started when create the second one

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 30, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 30, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-30 06:05:10.382344347 +0000 UTC m=+249426.662392415: ☑️ agreed by lance6716.
  • 2024-07-30 08:37:19.708045606 +0000 UTC m=+258555.988093675: ☑️ agreed by 3pointer.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, BornChanger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@D3Hunter
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Jul 30, 2024

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@D3Hunter
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Jul 30, 2024

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@D3Hunter
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Jul 30, 2024

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@D3Hunter
Copy link
Contributor Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented Jul 30, 2024

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 30, 2024

@D3Hunter: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-br-integration-test 02cf83f link true /test pull-br-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wuhuizuo
Copy link
Contributor

/retest

@tiprow tiprow
Copy link

tiprow bot commented Jul 30, 2024

@wuhuizuo: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 40ac334 into pingcap:master Jul 30, 2024
27 of 28 checks passed
@D3Hunter D3Hunter deleted the fix-br-domain branch July 30, 2024 10:56
hawkingrei pushed a commit to hawkingrei/tidb that referenced this pull request Aug 1, 2024
@D3Hunter @hawkingrei
br: fix br domain start (pingcap#55038)
26a438b 
close pingcap#55039
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BornChanger BornChanger BornChanger approved these changes

@3pointer 3pointer 3pointer approved these changes

@lance6716 lance6716 lance6716 left review comments

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

br block on create policy
5 participants
@D3Hunter @wuhuizuo @lance6716 @3pointer @BornChanger