-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: disable insert null to not-null column for single-row insertion in non-strict mode | tidb-test=pr/2410 #55477
Conversation
Hi @joechenrh. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #55477 +/- ##
================================================
+ Coverage 72.8567% 74.9721% +2.1153%
================================================
Files 1672 1717 +45
Lines 462738 474024 +11286
================================================
+ Hits 337136 355386 +18250
+ Misses 104829 96471 -8358
- Partials 20773 22167 +1394
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/unhold |
In response to a cherrypick label: new pull request created to branch |
… non-strict mode (pingcap#55477) close pingcap#55457, close pingcap#56381
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #55457, close #56381, close #57435
Problem Summary:
What changed and how does it work?
Accroding to MySQL document, even in non-strict mode, single null value still can not be inserted into not-null column.
To support this, this PR add a new error group
ErrGroupNoDefault
to detach the handling of default value from theErrGroupBadNull
.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.