Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: disable insert null to not-null column for single-row insertion in non-strict mode | tidb-test=pr/2410 #55477

Merged
merged 20 commits into from
Nov 19, 2024

Conversation

joechenrh
Copy link
Contributor

@joechenrh joechenrh commented Aug 16, 2024

What problem does this PR solve?

Issue Number: close #55457, close #56381, close #57435

Problem Summary:

What changed and how does it work?

Accroding to MySQL document, even in non-strict mode, single null value still can not be inserted into not-null column.

To support this, this PR add a new error group ErrGroupNoDefault to detach the handling of default value from the ErrGroupBadNull.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

- Report an error when inserting null to non-null column in non-strict mode

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 16, 2024
Copy link

tiprow bot commented Aug 16, 2024

Hi @joechenrh. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@joechenrh joechenrh marked this pull request as draft August 16, 2024 09:51
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 16, 2024
@joechenrh joechenrh marked this pull request as ready for review August 16, 2024 11:01
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 16, 2024
@joechenrh
Copy link
Contributor Author

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Aug 16, 2024
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.9721%. Comparing base (8382fdb) to head (cc158dd).
Report is 144 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #55477        +/-   ##
================================================
+ Coverage   72.8567%   74.9721%   +2.1153%     
================================================
  Files          1672       1717        +45     
  Lines        462738     474024     +11286     
================================================
+ Hits         337136     355386     +18250     
+ Misses       104829      96471      -8358     
- Partials      20773      22167      +1394     
Flag Coverage Δ
integration 49.8755% <92.8571%> (?)
unit 72.2780% <100.0000%> (+0.0408%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7673% <ø> (ø)
parser ∅ <ø> (∅)
br 60.7951% <ø> (+15.6921%) ⬆️

@joechenrh joechenrh marked this pull request as draft August 19, 2024 01:45
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 19, 2024
@joechenrh joechenrh marked this pull request as ready for review August 19, 2024 02:20
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 19, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 20, 2024
@ti-chi-bot ti-chi-bot bot removed the release-note-none Denotes a PR that doesn't merit a release note. label Nov 19, 2024
@djshow832
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2024
@ti-chi-bot ti-chi-bot bot merged commit 91beef4 into pingcap:master Nov 19, 2024
26 of 27 checks passed
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Nov 20, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #57539.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #58044.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 6, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #58045.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 6, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@YangKeao YangKeao added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Dec 6, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 6, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #58046.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 6, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #58047.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
9 participants