Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: disable insert null to not-null column for single-row insertion in non-strict mode | tidb-test=pr/2433 (#55477) #57539

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #55477

What problem does this PR solve?

Issue Number: close #55457, close #56381

Problem Summary:

What changed and how does it work?

Accroding to MySQL document, even in non-strict mode, single null value still can not be inserted into not-null column.

To support this, this PR add a new error group ErrGroupNoDefault to detach the handling of default value from the ErrGroupBadNull.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

- Report an error when inserting null to non-null column in non-strict mode

@ti-chi-bot ti-chi-bot added compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-8.5@562f614). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.5     #57539   +/-   ##
================================================
  Coverage               ?   57.4293%           
================================================
  Files                  ?       1770           
  Lines                  ?     631297           
  Branches               ?          0           
================================================
  Hits                   ?     362550           
  Misses                 ?     244854           
  Partials               ?      23893           
Flag Coverage Δ
integration 37.2925% <92.8571%> (?)
unit 73.1720% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 52.3224% <0.0000%> (?)
---- 🚨 Try these New Features:

Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 21, 2024
@djshow832 djshow832 requested a review from XuHuaiyu November 21, 2024 02:24
Copy link

ti-chi-bot bot commented Nov 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 21, 2024
Copy link

ti-chi-bot bot commented Nov 21, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-21 02:24:30.146627692 +0000 UTC m=+84857.766282208: ☑️ agreed by GMHDBJD.
  • 2024-11-21 02:42:15.228184774 +0000 UTC m=+85922.847839287: ☑️ agreed by XuHuaiyu.

@djshow832
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit 33c06b6 into pingcap:release-8.5 Nov 21, 2024
19 checks passed
@YangKeao YangKeao changed the title *: disable insert null to not-null column for single-row insertion in non-strict mode | tidb-test=pr/2410 (#55477) *: disable insert null to not-null column for single-row insertion in non-strict mode | tidb-test=pr/2433 (#55477) Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. lgtm ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants