planner: fix CTE hang or wrong result when multiple Apply is used

[guo-shaoge]

What problem does this PR solve?

Issue Number: close #55551

Problem Summary:
ExtractOuterApplyCorrelatedCols is used to find all correlated columns which is inside CTE definition and its corresponding Apply is outside of CTE definition. Check the following diagram, ExtractOuterApplyCorrelatedCols should NOT return cor_col_3, because cor_col_3's corresponding Apply is Apply_3, which is inside CTE definition.

Why need ExtractOuterApplyCorrelatedCols: For those CTE whose result of ExtractOuterApplyCorrelatedCols(CTE_definition) is not empty, we need to re-compute the definition of CTE.

// For Plan-2, the result of ExtractOuterApplyCorrelatedCols(CTE-2) will not return cor_col_3.
// Because Apply_3 is inside CTE-2.
// Plan-2:
//
//	Apply_2
//	 |_ outerSide
//	 |_ Selection(cor_col_2)
//	     |_CTEExec(CTE-2)
//	CTE-2
//	 |_ Apply_3
//	     |_ outerSide
//	     |_ innerSide(cor_col_3)

What changed and how does it work?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @guo-shaoge. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.9432%. Comparing base (51d57aa) to head (01b0d07).
Report is 299 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #55553        +/-   ##
================================================
+ Coverage   72.8423%   74.9432%   +2.1008%     
================================================
  Files          1572       1586        +14     
  Lines        440056     454220     +14164     
================================================
+ Hits         320547     340407     +19860     
+ Misses        99747      93210      -6537     
- Partials      19762      20603       +841     

Flag	Coverage Δ
integration	49.3405% <100.0000%> (?)
unit	71.9478% <100.0000%> (+0.0907%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9567% <ø> (ø)
parser	∅ <ø> (∅)
br	51.7416% <ø> (+5.9029%)	⬆️

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-08-21 07:25:16.33368126 +0000 UTC m=+336711.468131379: ☑️ agreed by hawkingrei.
• 2024-08-21 07:33:57.635152574 +0000 UTC m=+337232.769602696: ☑️ agreed by XuHuaiyu.

[guo-shaoge]

/hold

[tiprow]

@guo-shaoge: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
fast_test_tiprow	01b0d07	link	true	/test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [AilinKid,XuHuaiyu,hawkingrei]
• pkg/planner/OWNERS [AilinKid,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-6.5: #55643.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.5: #56200.

[guo-shaoge]

/run-cherry-picker

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-8.1: #56261.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.1: #56263.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-6.1: #56265.