-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: fix CTE hang or wrong result when multiple Apply is used (#55553) #56261
planner: fix CTE hang or wrong result when multiple Apply is used (#55553) #56261
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #56261 +/- ##
================================================
Coverage ? 71.2603%
================================================
Files ? 1466
Lines ? 423331
Branches ? 0
================================================
Hits ? 301667
Misses ? 101200
Partials ? 20464
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, XuHuaiyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
This is an automated cherry-pick of #55553
What problem does this PR solve?
Issue Number: close #55551
Problem Summary:
ExtractOuterApplyCorrelatedCols
is used to find all correlated columns which is inside CTE definition and its corresponding Apply is outside of CTE definition. Check the following diagram,ExtractOuterApplyCorrelatedCols
should NOT returncor_col_3
, becausecor_col_3
's corresponding Apply isApply_3
, which is inside CTE definition.Why need
ExtractOuterApplyCorrelatedCols
: For those CTE whose result ofExtractOuterApplyCorrelatedCols(CTE_definition)
is not empty, we need to re-compute the definition of CTE.What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.