Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: Truncate long VECTOR values in EXPLAIN #55930

Closed
wants to merge 6 commits into from
Closed

expression: Truncate long VECTOR values in EXPLAIN #55930

wants to merge 6 commits into from

Conversation

breezewish
Copy link
Member

@breezewish breezewish commented Sep 8, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #54245

Problem Summary:

What changed and how does it work?

Produce a better human readable EXPLAIN output by truncate long VECTOR constants.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@breezewish
expression: Truncate vectors and strings in EXPLAIN
119afa7 
Signed-off-by: Wish <breezewish@outlook.com>
@breezewish
Fix
f158799 
Signed-off-by: Wish <breezewish@outlook.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. labels Sep 8, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 8, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zanmato1984 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Sep 8, 2024
@breezewish
Merge remote-tracking branch 'origin/master' into wenxuan/truncate-vecs
87c4984 
* origin/master: (33 commits)
  build(deps): bump github.com/prometheus/common from 0.55.0 to 0.57.0 (pingcap#55762)
  build(deps): bump golang.org/x/sys from 0.24.0 to 0.25.0 (pingcap#55894)
  planner: fix incorrect estRows with global index and json column (pingcap#55842)
  ddl, stat: switch to new struct for add/truncate/drop partition (pingcap#55893)
  planner: hide instance plan cache eviction log if no plan is evicted (pingcap#55918)
  expression: support tidb encode key function (pingcap#51678)
  planner: fix incorrect maintenance of `handleColHelper` for recursive CTE (pingcap#55732)
  executor: some code refine of hash join v2 (pingcap#55887)
  infoschema, meta: fix wrong auto id after `rename table` (pingcap#55847)
  ddl/ingest: set `minCommitTS` when detect remote duplicate keys (pingcap#55588)
  planner: move index advisor into the kernel (pingcap#55874)
  ddl, stats: switch to new struct for create/truncate table (pingcap#55811)
  executor: avoid new small objects in probe stage of hash join v2 (pingcap#55855)
  *: Add tidbCPU/tikvCPU into system tables (pingcap#55455)
  ddl: use static contexts in `NewReorgCopContext` (pingcap#55823)
  executor: fix index out of range bug in hash join v2 (pingcap#55864)
  executor: record index usage for the clustered primary keys (pingcap#55602)
  domain: load all non-public tables into infoschema (pingcap#55142)
  test: fix unstable TestShowViewPriv (pingcap#55868)
  ttl: add `varbinary` case for `TestSplitTTLScanRangesWithBytes` (pingcap#55863)
  ...
@breezewish
Fix
d14b3b9 
Signed-off-by: Wish <breezewish@outlook.com>
@breezewish
Fix
7a69600 
Signed-off-by: Wish <breezewish@outlook.com>
@breezewish
Simplify
bd49324 
Signed-off-by: Wish <breezewish@outlook.com>
@codecov Codecov
Copy link

codecov bot commented Sep 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 41.07143% with 33 lines in your changes missing coverage. Please review.

Project coverage is 55.4506%. Comparing base (47bbca3) to head (bd49324).
Report is 191 commits behind head on master.

Additional details and impacted files 
@@                Coverage Diff                @@
##             master     #55930         +/-   ##
=================================================
- Coverage   72.9119%   55.4506%   -17.4613%     
=================================================
  Files          1604       1723        +119     
  Lines        445665     616831     +171166     
=================================================
+ Hits         324943     342037      +17094     
- Misses       100688     252070     +151382     
- Partials      20034      22724       +2690
Flag Coverage Δ
integration 35.0420% <41.0714%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 46.1618% <ø> (+0.3852%) ⬆️

@tiprow tiprow
Copy link

tiprow bot commented Sep 8, 2024

@breezewish: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow bd49324 link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 8, 2024

@breezewish: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev_2 bd49324 link true /test check-dev2
idc-jenkins-ci-tidb/unit-test bd49324 link true /test unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 29, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 29, 2024
@breezewish
Copy link
Member Author

Close for #55934

@breezewish breezewish closed this Sep 29, 2024
@breezewish breezewish deleted the wenxuan/truncate-vecs branch September 29, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@breezewish