-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
txn: use handle to encode checksum instead of the key (#57139) #57186
txn: use handle to encode checksum instead of the key (#57139) #57186
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #57186 +/- ##
================================================
Coverage ? 56.9265%
================================================
Files ? 1780
Lines ? 640432
Branches ? 0
================================================
Hits ? 364576
Misses ? 251760
Partials ? 24096
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
/retest |
2 similar comments
/retest |
/retest |
/test pull-unit-test-ddlv1 |
@3AceShowHand: No presubmit jobs available for pingcap/tidb@release-8.5 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3AceShowHand, GMHDBJD, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #57139
What problem does this PR solve?
Issue Number: close #57174
Problem Summary:
When BR restore data, they may alter the key, but the checksum part in the value not touched.
Since the checksum is calculated based on the value and key toghter, so the checksum verification may wrong since using the altered key.
What changed and how does it work?
Using handle to calculate checksum, to skip the table id change problem. The handle is not changed.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.