Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txn: use handle to encode checksum instead of the key (#57139) #57186

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #57139

What problem does this PR solve?

Issue Number: close #57174

Problem Summary:

When BR restore data, they may alter the key, but the checksum part in the value not touched.
Since the checksum is calculated based on the value and key toghter, so the checksum verification may wrong since using the altered key.

What changed and how does it work?

Using handle to calculate checksum, to skip the table id change problem. The handle is not changed.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Nov 6, 2024
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 58.82353% with 7 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.5@4fb27d5). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.5     #57186   +/-   ##
================================================
  Coverage               ?   56.9265%           
================================================
  Files                  ?       1780           
  Lines                  ?     640432           
  Branches               ?          0           
================================================
  Hits                   ?     364576           
  Misses                 ?     251760           
  Partials               ?      24096           
Flag Coverage Δ
integration 37.7058% <11.7647%> (?)
unit 73.1006% <58.8235%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 52.5528% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Nov 8, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 8, 2024
@3AceShowHand
Copy link
Contributor

/retest

2 similar comments
@3AceShowHand
Copy link
Contributor

/retest

@3AceShowHand
Copy link
Contributor

/retest

@3AceShowHand
Copy link
Contributor

/test pull-unit-test-ddlv1

Copy link

tiprow bot commented Nov 13, 2024

@3AceShowHand: No presubmit jobs available for pingcap/tidb@release-8.5

In response to this:

/test pull-unit-test-ddlv1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 14, 2024
Copy link

ti-chi-bot bot commented Nov 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-08 08:29:51.559364638 +0000 UTC m=+1202504.398520185: ☑️ agreed by 3AceShowHand.
  • 2024-11-14 06:12:27.282843081 +0000 UTC m=+509509.473712071: ☑️ agreed by GMHDBJD.

Copy link

ti-chi-bot bot commented Nov 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, GMHDBJD, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 70b8a30 into pingcap:release-8.5 Nov 14, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants