txn: bump checksum version #57205

3AceShowHand · 2024-11-07T09:24:09Z

What problem does this PR solve?

Issue Number: close #57206

Problem Summary:

What changed and how does it work?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

deploy tidb cluster v8.3.0

create table t(a int primary key, b int);
insert into t values (1, 2);

upgrade tidb to v8.4.0

update t set b = 3 where a = 1;

update t set a = 2 where a = 1;

output:


[2024/11/07 18:50:10.138 +08:00] [INFO] [mounter.go:636] ["raw bytes checksum matched"] [version=1] [expected=1383743328] [obtained=1383743328]

[2024/11/07 18:55:49.438 +08:00] [INFO] [mounter.go:636] ["raw bytes checksum matched"] [version=1] [expected=1383743328] [obtained=1383743328]
[2024/11/07 18:55:49.438 +08:00] [INFO] [mounter.go:636] ["raw bytes checksum matched"] [version=2] [expected=3631181330] [obtained=3631181330]

[2024/11/07 18:56:07.438 +08:00] [INFO] [mounter.go:636] ["raw bytes checksum matched"] [version=2] [expected=3631181330] [obtained=3631181330]
[2024/11/07 18:56:07.438 +08:00] [INFO] [mounter.go:636] ["raw bytes checksum matched"] [version=2] [expected=1097220008] [obtained=1097220008]

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

tiprow · 2024-11-07T09:24:25Z

Hi @3AceShowHand. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

codecov · 2024-11-07T09:38:01Z

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 56.9810%. Comparing base (d1652cf) to head (da918c8).
Report is 4 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #57205         +/-   ##
=================================================
- Coverage   72.9613%   56.9810%   -15.9804%     
=================================================
  Files          1659       1810        +151     
  Lines        458506     645352     +186846     
=================================================
+ Hits         334532     367728      +33196     
- Misses       103446     252305     +148859     
- Partials      20528      25319       +4791

Flag	Coverage Δ
integration	`39.2804% <0.0000%> (?)`
unit	`72.3049% <41.6666%> (+0.0079%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.9478% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`61.7964% <ø> (+16.7545%)`	⬆️

tangenta · 2024-11-07T10:04:45Z

pkg/util/rowcodec/encoder.go

+// introduced since v7.1.0
+// bumped to 1 since v8.3.0
+// bumped to 2 since v8.4.0
+const checksumVersionRaw byte = 2


Is it better to use three constants instead and describe what's changed in the comment for each of them?

pkg/util/rowcodec/row.go

ti-chi-bot · 2024-11-07T10:29:01Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tangenta, zyguan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [tangenta,zyguan]
~~pkg/ddl/OWNERS~~ [tangenta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2024-11-07T10:29:05Z

[LGTM Timeline notifier]

Timeline:

2024-11-07 10:03:32.898567169 +0000 UTC m=+1121725.737722713: ☑️ agreed by tangenta.
2024-11-07 10:29:03.887901846 +0000 UTC m=+1123256.727057393: ☑️ agreed by zyguan.

3AceShowHand · 2024-11-07T10:29:13Z

/hold

3AceShowHand · 2024-11-07T10:57:26Z

/unhold

3AceShowHand · 2024-11-07T10:57:55Z

/retest

tiprow · 2024-11-07T10:58:18Z

@3AceShowHand: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

3AceShowHand · 2024-11-07T10:58:54Z

/test fast_test_tiprow

ti-chi-bot · 2024-11-07T10:58:58Z

@3AceShowHand: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build
/test check-dev
/test check-dev2
/test mysql-test
/test pull-br-integration-test
/test pull-integration-ddl-test
/test pull-lightning-integration-test
/test pull-mysql-client-test
/test pull-unit-test-ddlv1
/test unit-test

The following commands are available to trigger optional jobs:

/test pingcap/tidb/canary_ghpr_unit_test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-e2e-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-integration-nodejs-test
/test pull-sqllogic-test
/test pull-tiflash-test

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test
pingcap/tidb/pull_br_integration_test
pingcap/tidb/pull_integration_ddl_test
pingcap/tidb/pull_lightning_integration_test
pingcap/tidb/pull_mysql_client_test
pingcap/tidb/pull_unit_test_ddlv1

In response to this:

/test fast_test_tiprow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow · 2024-11-07T10:59:18Z

@3AceShowHand: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test fast_test_tiprow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

3AceShowHand · 2024-11-07T10:59:37Z

/test fast_test_tiprow

ti-chi-bot · 2024-11-07T10:59:41Z

@3AceShowHand: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build
/test check-dev
/test check-dev2
/test mysql-test
/test pull-br-integration-test
/test pull-integration-ddl-test
/test pull-lightning-integration-test
/test pull-mysql-client-test
/test pull-unit-test-ddlv1
/test unit-test

The following commands are available to trigger optional jobs:

/test pingcap/tidb/canary_ghpr_unit_test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-e2e-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-integration-nodejs-test
/test pull-sqllogic-test
/test pull-tiflash-test

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test
pingcap/tidb/pull_br_integration_test
pingcap/tidb/pull_integration_ddl_test
pingcap/tidb/pull_lightning_integration_test
pingcap/tidb/pull_mysql_client_test
pingcap/tidb/pull_unit_test_ddlv1

In response to this:

/test fast_test_tiprow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow · 2024-11-07T10:59:59Z

@3AceShowHand: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test fast_test_tiprow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

3AceShowHand · 2024-11-07T11:00:02Z

/ok-to-test

3AceShowHand · 2024-11-07T11:07:43Z

/retest

3AceShowHand · 2024-11-07T11:56:36Z

/retest

ti-chi-bot · 2024-11-07T13:13:13Z

In response to a cherrypick label: new pull request created to branch release-8.4: #57219.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot · 2024-11-07T13:16:12Z

In response to a cherrypick label: new pull request created to branch release-8.5: #57220.

close #57206

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

bump checksum version

39b71e8

ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 7, 2024

ti-chi-bot bot removed do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked labels Nov 7, 2024

bump checksum version

00f6e0f

3AceShowHand added 2 commits November 7, 2024 17:38

fix some ut

2ab7b2d

add some comment.

1e2b517

3AceShowHand requested review from zyguan and tangenta November 7, 2024 09:47

tangenta approved these changes Nov 7, 2024

View reviewed changes

ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 7, 2024

tangenta reviewed Nov 7, 2024

View reviewed changes

zyguan reviewed Nov 7, 2024

View reviewed changes

pkg/util/rowcodec/row.go Show resolved Hide resolved

fix by review

43ae6ab

ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 7, 2024

fix by review

b5e132b

3AceShowHand requested a review from zyguan November 7, 2024 10:25

zyguan approved these changes Nov 7, 2024

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 7, 2024

ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2024

ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2024

ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Nov 7, 2024

Merge branch 'master' into checksum-by-key

bc18664

ti-chi-bot bot added the needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. label Nov 7, 2024

fix ut data

da918c8

ti-chi-bot bot merged commit e2505e9 into pingcap:master Nov 7, 2024
26 checks passed

ti-chi-bot mentioned this pull request Nov 7, 2024

txn: bump checksum version (#57205) #57219

Merged

13 tasks

3AceShowHand added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Nov 7, 2024

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Nov 7, 2024

This is an automated cherry-pick of pingcap#57205

cdbdfe1

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Nov 7, 2024

txn: bump checksum version (#57205) #57220

Closed

13 tasks

ti-chi-bot bot pushed a commit that referenced this pull request Nov 7, 2024

txn: bump checksum version (#57205) (#57219)

1a9f0fa

close #57206

3AceShowHand added a commit to ti-chi-bot/tidb that referenced this pull request Nov 8, 2024

This is an automated cherry-pick of pingcap#57205

dcdfc7a

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot bot removed the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Nov 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

txn: bump checksum version #57205

txn: bump checksum version #57205

3AceShowHand commented Nov 7, 2024 •

edited

Loading

tiprow bot commented Nov 7, 2024

codecov bot commented Nov 7, 2024 •

edited

Loading

tangenta Nov 7, 2024

ti-chi-bot bot commented Nov 7, 2024

ti-chi-bot bot commented Nov 7, 2024

3AceShowHand commented Nov 7, 2024

3AceShowHand commented Nov 7, 2024

3AceShowHand commented Nov 7, 2024

tiprow bot commented Nov 7, 2024

3AceShowHand commented Nov 7, 2024

ti-chi-bot bot commented Nov 7, 2024

tiprow bot commented Nov 7, 2024

3AceShowHand commented Nov 7, 2024

ti-chi-bot bot commented Nov 7, 2024

tiprow bot commented Nov 7, 2024

3AceShowHand commented Nov 7, 2024

3AceShowHand commented Nov 7, 2024

3AceShowHand commented Nov 7, 2024

ti-chi-bot commented Nov 7, 2024

ti-chi-bot commented Nov 7, 2024

txn: bump checksum version #57205

txn: bump checksum version #57205

Conversation

3AceShowHand commented Nov 7, 2024 • edited Loading

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

tiprow bot commented Nov 7, 2024

codecov bot commented Nov 7, 2024 • edited Loading

Codecov Report

tangenta Nov 7, 2024

Choose a reason for hiding this comment

ti-chi-bot bot commented Nov 7, 2024

ti-chi-bot bot commented Nov 7, 2024

[LGTM Timeline notifier]

3AceShowHand commented Nov 7, 2024

3AceShowHand commented Nov 7, 2024

3AceShowHand commented Nov 7, 2024

tiprow bot commented Nov 7, 2024

3AceShowHand commented Nov 7, 2024

ti-chi-bot bot commented Nov 7, 2024

tiprow bot commented Nov 7, 2024

3AceShowHand commented Nov 7, 2024

ti-chi-bot bot commented Nov 7, 2024

tiprow bot commented Nov 7, 2024

3AceShowHand commented Nov 7, 2024

3AceShowHand commented Nov 7, 2024

3AceShowHand commented Nov 7, 2024

ti-chi-bot commented Nov 7, 2024

ti-chi-bot commented Nov 7, 2024

3AceShowHand commented Nov 7, 2024 •

edited

Loading

codecov bot commented Nov 7, 2024 •

edited

Loading