Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txn: bump checksum version (#57205) #57219

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #57205

What problem does this PR solve?

Issue Number: close #57206

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.
deploy tidb cluster v8.3.0

create table t(a int primary key, b int);
insert into t values (1, 2);

upgrade tidb to v8.4.0

update t set b = 3 where a = 1;

update t set a = 2 where a = 1;

output:


[2024/11/07 18:50:10.138 +08:00] [INFO] [mounter.go:636] ["raw bytes checksum matched"] [version=1] [expected=1383743328] [obtained=1383743328]

[2024/11/07 18:55:49.438 +08:00] [INFO] [mounter.go:636] ["raw bytes checksum matched"] [version=1] [expected=1383743328] [obtained=1383743328]
[2024/11/07 18:55:49.438 +08:00] [INFO] [mounter.go:636] ["raw bytes checksum matched"] [version=2] [expected=3631181330] [obtained=3631181330]

[2024/11/07 18:56:07.438 +08:00] [INFO] [mounter.go:636] ["raw bytes checksum matched"] [version=2] [expected=3631181330] [obtained=3631181330]
[2024/11/07 18:56:07.438 +08:00] [INFO] [mounter.go:636] ["raw bytes checksum matched"] [version=2] [expected=1097220008] [obtained=1097220008]

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.4 labels Nov 7, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 7, 2024
13 tasks
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.4@d39b71b). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.4     #57219   +/-   ##
================================================
  Coverage               ?   56.1870%           
================================================
  Files                  ?       1742           
  Lines                  ?     616737           
  Branches               ?          0           
================================================
  Hits                   ?     346526           
  Misses                 ?     247163           
  Partials               ?      23048           
Flag Coverage Δ
integration 34.9686% <0.0000%> (?)
unit 72.4604% <41.6666%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 45.7535% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 7, 2024
Copy link

ti-chi-bot bot commented Nov 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 7, 2024
Copy link

ti-chi-bot bot commented Nov 7, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-07 14:41:48.912995973 +0000 UTC m=+1138421.752151518: ☑️ agreed by 3AceShowHand.
  • 2024-11-07 15:07:01.61841375 +0000 UTC m=+1139934.457569294: ☑️ agreed by tangenta.

@ti-chi-bot ti-chi-bot bot merged commit 1a9f0fa into pingcap:release-8.4 Nov 7, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants