Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner/core: fix index resolution on PhysicalIndexReader #8118

Merged
merged 6 commits into from
Oct 31, 2018

Conversation

zz-jason
Copy link
Member

What problem does this PR solve?

the Column.Index of handle column resolved in the PhysicalIndexReader.OutputColumns is not correct.

What is changed and how it works?

directly resolve the index based on the schema of child PhysicalIndexScan.

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

@zz-jason zz-jason added type/bugfix This PR fixes a bug. sig/planner SIG: Planner labels Oct 31, 2018
@zz-jason
Copy link
Member Author

/run-all-tests

@zz-jason
Copy link
Member Author

@winoros @eurekaka @lamxTyler PTAL

executor/executor_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 31, 2018
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jackysp jackysp merged commit c23a30c into pingcap:master Oct 31, 2018
@zz-jason zz-jason deleted the bugfix/indexreader branch November 1, 2018 04:33
@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 1, 2018
zz-jason added a commit to zz-jason/tidb that referenced this pull request Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants