Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner/core: fix index resolution on PhysicalIndexReader (#8118) #8132

Merged
merged 2 commits into from
Nov 1, 2018

Conversation

zz-jason
Copy link
Member

@zz-jason zz-jason commented Nov 1, 2018

cherrypick #8118 to release 2.1

Check List

Tests

  • Unit test

Related changes

  • Need to be included in the release note

@zz-jason zz-jason added type/bugfix This PR fixes a bug. sig/planner SIG: Planner type/2.1 cherry-pick labels Nov 1, 2018
@zz-jason
Copy link
Member Author

zz-jason commented Nov 1, 2018

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@winoros
Copy link
Member

winoros commented Nov 1, 2018

It built failed.

@zz-jason
Copy link
Member Author

zz-jason commented Nov 1, 2018

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 1, 2018
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zimulala zimulala added the status/LGT2 Indicates that a PR has LGTM 2. label Nov 1, 2018
@zz-jason zz-jason merged commit adb5733 into pingcap:release-2.1 Nov 1, 2018
@zz-jason zz-jason deleted the cherrypick/indexreader branch November 1, 2018 08:30
@zz-jason zz-jason removed the status/LGT1 Indicates that a PR has LGTM 1. label Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants