Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser/opcode: fix format function for mod opcode (#7455) #8431

Merged
merged 2 commits into from
Nov 26, 2018

Conversation

tiancaiamao
Copy link
Contributor

@tiancaiamao tiancaiamao commented Nov 24, 2018

Cherry-pick from #7455 to release-2.0
This is a parser bug, but it may cause trouble for DDL

@winkyao @lysu @hicqu


This change is Reviewable

@tiancaiamao
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.0 pd=release-2.0 tikv=release-2.0

@zz-jason zz-jason added type/bugfix This PR fixes a bug. component/parser labels Nov 26, 2018
@zz-jason
Copy link
Member

LGTM

@zz-jason
Copy link
Member

/run-all-tests tidb-test=release-2.0 pd=release-2.0 tikv=release-2.0

@zz-jason
Copy link
Member

@lysu @jackysp PTAL

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 26, 2018
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp merged commit e6c84be into pingcap:release-2.0 Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/parser status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants