parser/opcode: fix format function for mod opcode #7455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
lysu
reviewed
Aug 21, 2018
| @@ -134,5 +134,5 @@ var opsLiteral = map[Op]string{ | |||
|
|
|||
| // Format the ExprNode into a Writer. | |||
| func (o Op) Format(w io.Writer) { | |||
| fmt.Fprintf(w, opsLiteral[o]) | |||
| fmt.Fprintf(w, "%s", opsLiteral[o]) | |||
There was a problem hiding this comment.
maybe w.Write([]byte(opsLiteral[o])) is better? 0.0?
There was a problem hiding this comment.
or make opsLiteral be map[Op][]byte then w.write(opsLiteral[o])
There was a problem hiding this comment.
There is still a memory allocation in w.Write([]byte(opsLiteral[o])) when converting string to []byte.
If you want better performance, the 'hack' could be used, but I don't think it matters here.
tiancaiamao
added a commit
to tiancaiamao/tidb
that referenced
this pull request
Nov 24, 2018
jackysp
pushed a commit
that referenced
this pull request
Nov 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Before this fix, format
Modopcode will get%!(NOVERB)What is changed and how it works?
Use fmt.Printf correctly.
Check List
Tests
@lysu @jackysp