parser/opcode: fix format function for mod opcode (pingcap#7455)

tiancaiamao · Nov 24, 2018 · d4c968e · d4c968e
1 parent 3f03b30
commit d4c968e
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/parser/opcode/opcode.go b/parser/opcode/opcode.go
@@ -134,5 +134,5 @@ var opsLiteral = map[Op]string{
 
 // Format the ExprNode into a Writer.
 func (o Op) Format(w io.Writer) {
-	fmt.Fprintf(w, opsLiteral[o])
+	fmt.Fprintf(w, "%s", opsLiteral[o])
 }
diff --git a/parser/opcode/opcode_test.go b/parser/opcode/opcode_test.go
@@ -13,14 +13,29 @@
 
 package opcode
 
-import "testing"
+import (
+	"bytes"
+	"testing"
+)
 
 func TestT(t *testing.T) {
 	op := Plus
 	if op.String() != "plus" {
 		t.Fatalf("invalid op code")
 	}
 
+	if len(Ops) != len(opsLiteral) {
+		t.Error("inconsistent count ops and opsliteral")
+	}
+	var buf bytes.Buffer
+	for op := range Ops {
+		op.Format(&buf)
+		if buf.String() != opsLiteral[op] {
+			t.Error("format op fail", op)
+		}
+		buf.Reset()
+	}
+
 	// Test invalid opcode
 	defer func() {
 		recover()