Log warning instead of throw exception when meets big region #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solotzg
approved these changes
Nov 1, 2019
JaySon-Huang
force-pushed
the
pagestorage-big-region-exception
branch
from
364f39c to
d521a37
Compare
|
/run-integration-tests |
12 tasks
CalvinNeo
added a commit
to CalvinNeo/tiflash
that referenced
this pull request
Nov 5, 2024
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix
Now PageStorage support region with size over 4GB, but
RegionPersisterstill throw exception when meets big region.This PR log warnings instead of throw exception.
Related PR
#301