-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce duplication of DM's syncer and CDC's MySQL sink #3242
Comments
can I have a try to make a pull request? |
thanks! we’re looking forward to your contribution. also please keep pr in a small size, that’s better for reviewing. |
ok |
Causality detection is also a common library used both in DM and TiCDC. ref: https://github.com/pingcap/ticdc/issues/3286 |
some comparison of DML part of mysqlSink and Syncer dml comes from:
processing stages:
compact
generate DML:
batch a SQL transactoin
cyclic replication
|
noticed there're lot of functions can be reused:
(a finished item)
https://github.com/pingcap/ticdc/blob/4bc1853a10287f12aff5706123c0cfc39feae7d2/cdc/sink/mysql.go#L1203 vs https://github.com/pingcap/ticdc/blob/4bc1853a10287f12aff5706123c0cfc39feae7d2/dm/syncer/dml.go#L713
sink/causality.go vs syncer/causality.go
The text was updated successfully, but these errors were encountered: