s3Sink: cancel create existing table directory on s3 when initialize s3Sink

[dengqee]

s3Sink: cancel create existing table directory on s3 when initialize s3Sink

fix bug #1463 reported

What problem does this PR solve?

fix bug #1463 reported

What is changed and how it works?

https://github.com/pingcap/ticdc/blob/355016c0ee9d689fe203db57a18449afe26271d9/cdc/sink/cdclog/s3.go#L318-L327
S3 does not create an empty directory. This code causes S3 to create objects instead of directories, like this:

Uploading objects to these directories will cause an error, like:

"code": "CDC:ErrProcessorUnknown",
"message": "[CDC:ErrS3SinkStorageAPI]XMinioParentIsObject: Object-prefix is already an object, please choose a different object-prefix name.\n\tstatus code: 400, request id: 166825DDCC17A799, host id: "

So I deleted the code.

Check List

Tests

• Manual test (add detailed scripts or steps below)
• No code

Code changes

• Has exported function/method change

Side effects

• Possible performance regression

Related changes

• Need to cherry-pick to the release branch

Release note

• s3Sink: cancel create existing table directory on s3 when initialize s3Sink to avoid uploading objects faild

[dengqee]

@3pointer @amyangfei @leoppro PTAL

[dengqee]

@3pointer @amyangfei @leoppro PTAL

[amyangfei]

Thanks!
I have a question about the behavior of S3, when uploading a file such as t_60/cdclog.xxxxxxxx, will the directory t_60 be created automatically?
Besides, could you please add this case to existing integration test tests/cdclog_s3

[dengqee]

Thanks!
I have a question about the behavior of S3, when uploading a file such as t_60/cdclog.xxxxxxxx, will the directory t_60 be created automatically?
Besides, could you please add this case to existing integration test tests/cdclog_s3

Yes, S3 will create the directoryt_60 automatically when upload a file like t_60/cdclog.xxxxxxxx. And if you delete all files in a directory on S3, the directory will be deleted automatically.
I will try to add this case to integration test.

[amyangfei]

LGTM

[dengqee]

@3pointer @leoppro PTAL

[dengqee]

@3pointer PTAL

[3pointer]

LGTM

[overvenus]

/lgtm

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

[overvenus]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 087c6da

[amyangfei]

/run-all-tests

[ti-srebot]

cherry pick to release-4.0 in PR #1671

[ti-srebot]

cherry pick to release-5.0 in PR #1672