-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
s3Sink: cancel create existing table directory on s3 when initialize s3Sink (#1477) #1672
s3Sink: cancel create existing table directory on s3 when initialize s3Sink (#1477) #1672
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
/lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 36d4910
|
cherry-pick #1477 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In ticdc repo: git pr https://github.com/pingcap/ticdc/pull/1672
After apply modifications, you can push your change to this PR via:
s3Sink: cancel create existing table directory on s3 when initialize s3Sink
fix bug #1463 reported
What problem does this PR solve?
fix bug #1463 reported
What is changed and how it works?
https://github.com/pingcap/ticdc/blob/355016c0ee9d689fe203db57a18449afe26271d9/cdc/sink/cdclog/s3.go#L318-L327
S3 does not create an empty directory. This code causes S3 to create objects instead of directories, like this:
Uploading objects to these directories will cause an error, like:
So I deleted the code.
Check List
Tests
Code changes
Side effects
Related changes
Release note