cluster: add significant warning destroying a cluster (#1723)

pingcap · Jan 14, 2022 · ff446c1 · ff446c1
1 parent 7bfbed1
commit ff446c1
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 7 deletions.
diff --git a/pkg/cluster/manager/destroy.go b/pkg/cluster/manager/destroy.go
@@ -52,11 +52,15 @@ func (m *Manager) DestroyCluster(name string, gOpt operator.Options, destroyOpt
 	}
 
 	if !skipConfirm {
-		if err := tui.PromptForConfirmOrAbortError(
-			"This operation will destroy %s %s cluster %s and its data.\nDo you want to continue? [y/N]:",
-			m.sysName,
-			color.HiYellowString(base.Version),
-			color.HiYellowString(name)); err != nil {
+		m.logger.Warnf(color.HiRedString(tui.ASCIIArtWarning))
+		if err := tui.PromptForAnswerOrAbortError(
+			"Yes, I know my cluster and data will be deleted.",
+			fmt.Sprintf("This operation will destroy %s %s cluster %s and its data.",
+				m.sysName,
+				color.HiYellowString(base.Version),
+				color.HiYellowString(name),
+			)+"\nAre you sure to continue?",
+		); err != nil {
 			return err
 		}
 		m.logger.Infof("Destroying cluster...")

diff --git a/tests/tiup-cluster/script/upgrade.sh b/tests/tiup-cluster/script/upgrade.sh
@@ -48,5 +48,5 @@ EOEX
 
     tiup-cluster _test $name writable
 
-    yes | tiup-cluster destroy $name
+    tiup-cluster --yes destroy $name
 }
diff --git a/tests/tiup-dm/test_upgrade.sh b/tests/tiup-dm/test_upgrade.sh
@@ -38,4 +38,4 @@ tiup-dm exec $name -N "$ipprefix.104:8261" --command "grep '31s' /home/tidb/depl
 ./script/task/run.sh
 
 
-yes | tiup-dm destroy $name
+tiup-dm --yes destroy $name
Original file line number	Diff line number	Diff line change
Expand Up		@@ -38,4 +38,4 @@ tiup-dm exec $name -N "$ipprefix.104:8261" --command "grep '31s' /home/tidb/depl
		./script/task/run.sh


		yes \| tiup-dm destroy $name
		tiup-dm --yes destroy $name