-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster: add significant warning destroying a cluster #1723
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the test script need to be modified duo the change of "y"
Codecov Report
@@ Coverage Diff @@
## master #1723 +/- ##
===========================================
+ Coverage 24.43% 50.25% +25.83%
===========================================
Files 277 300 +23
Lines 31449 34172 +2723
===========================================
+ Hits 7682 17173 +9491
+ Misses 22914 15022 -7892
- Partials 853 1977 +1124
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
52c6e76
to
b175ec1
Compare
b175ec1
to
741f769
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 741f769
|
What problem does this PR solve?
Close #1722
What is changed and how it works?
Add a significant warning when the users tries to destroy a cluster. It requires the user to input a long sentence to confirm (instead of a simple "Y/y" letter) so it's highly not possible for the user to destroy a cluster by mistake.
Check List
Tests
Release notes: