Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TiUP cluster scale out don't automatically pull up cluster all component instances #823

Closed
wentaojin opened this issue Sep 28, 2020 · 0 comments · Fixed by #848
Closed

TiUP cluster scale out don't automatically pull up cluster all component instances #823

wentaojin opened this issue Sep 28, 2020 · 0 comments · Fixed by #848
Labels
status/TODO Categorizes issue as we will do it. type/enhancement Categorizes issue or PR as related to an enhancement.
Milestone
v1.2.1

Comments

@wentaojin
Copy link
Contributor

wentaojin commented Sep 28, 2020 •
edited
Loading

When using tiup to scale out tidb nodes, all component instances need to be pulled up for safety. However, it may occur when the component instance is running normally. Some unknown factors cause tiup ssh to pull up the component instance to run commands, which may result in failure to scale out the tidb node.

So，suggest not pull up when scale out ，this is left to the user to check Or provide skip parameter option --skip-start
@wentaojin wentaojin added the type/feature-request Categorizes issue as related to a new feature. label Sep 28, 2020
@lucklove lucklove added the status/TODO Categorizes issue as we will do it. label Sep 28, 2020
@lucklove lucklove added type/enhancement Categorizes issue or PR as related to an enhancement. and removed type/feature-request Categorizes issue as related to a new feature. labels Oct 12, 2020
@lucklove lucklove added this to the v1.2.1 milestone Oct 12, 2020
lucklove added a commit to lucklove/tiup that referenced this issue Oct 16, 2020
@lucklove
Skip atuo-start cluster before scale-out action
1d6c6ee 
Fix pingcap#823

Signed-off-by: lucklove <gnu.crazier@gmail.com>
@lucklove lucklove mentioned this issue Oct 16, 2020
Merged
lucklove added a commit that referenced this issue Oct 19, 2020
@lucklove
Skip atuo-start cluster before scale-out action (#848)
6fc2fb9 
Fix #823

Signed-off-by: lucklove <gnu.crazier@gmail.com>
lucklove added a commit that referenced this issue Oct 23, 2020
@lucklove
Skip atuo-start cluster before scale-out action (#848)
d354959 
Fix #823

Signed-off-by: lucklove <gnu.crazier@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status/TODO Categorizes issue as we will do it. type/enhancement Categorizes issue or PR as related to an enhancement.
Projects
None yet
Milestone
v1.2.1
Development

Successfully merging a pull request may close this issue.

Skip atuo-start cluster before scale-out action lucklove/tiup
2 participants
@lucklove @wentaojin