Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip atuo-start cluster before scale-out action #848

Merged
merged 1 commit into from
Oct 19, 2020

Conversation

lucklove
Copy link
Member

Fix #823

Signed-off-by: lucklove gnu.crazier@gmail.com

What problem does this PR solve?

Fix #823

What is changed and how it works?

Skip auto-start because before any really action, tiup need to check the labels set in PD(

if topo, ok := topo.(*spec.Specification); ok {
), which implies that the PDs must be started.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release notes:

NONE

Fix pingcap#823

Signed-off-by: lucklove <gnu.crazier@gmail.com>
@lucklove lucklove added type/enhancement Categorizes issue or PR as related to an enhancement. status/PTAL labels Oct 16, 2020
@lucklove lucklove added this to the v1.2.1 milestone Oct 16, 2020
@lucklove lucklove requested a review from lonng October 16, 2020 10:44
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 17, 2020
@lucklove lucklove merged commit 6fc2fb9 into pingcap:master Oct 19, 2020
lucklove added a commit that referenced this pull request Oct 23, 2020
Fix #823

Signed-off-by: lucklove <gnu.crazier@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT1 Indicates that a PR has LGTM 1. type/enhancement Categorizes issue or PR as related to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TiUP cluster scale out don't automatically pull up cluster all component instances
3 participants