cluster: add subcommand pull and push to transfer files #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AstroProfundis
added
type/new-feature
ti-chi-bot
added
the
size/L
Codecov Report
@@ Coverage Diff @@
## master #1044 +/- ##
==========================================
+ Coverage 55.80% 55.92% +0.11%
==========================================
Files 280 282 +2
Lines 19759 19860 +101
==========================================
+ Hits 11026 11106 +80
- Misses 7029 7032 +3
- Partials 1704 1722 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
AstroProfundis
force-pushed
the
subcmd-transfer
branch
from
69a5f6d to
9c09b4e
Compare
ti-chi-bot
removed
the
do-not-merge/work-in-progress
|
Please add some test for this. |
lucklove
reviewed
Jan 7, 2021
| } | ||
|
|
||
| func renderSpec(t string, s interface{}, id string) (string, error) { | ||
| tpl, err := template.New(id).Option("missingkey=error").Parse(t) |
There was a problem hiding this comment.
I have write a playground, this should work: https://play.golang.org/p/ZP1fQgRmkFM
|
/lgtm |
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 50b5b49
|
ti-chi-bot
added
the
status/can-merge
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Add a pair of subcommand
pull/pushtocluster, theseadbstyle commands are used to transfer files from or to servers in the cluster.Fields in node component specification can be used as template for remote paths.
Check List
Tests
Code changes
Side effects
Release notes: