Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix push with template #1049

Merged
merged 3 commits into from
Jan 8, 2021
Merged

Fix push with template #1049

merged 3 commits into from
Jan 8, 2021

Conversation

lucklove
Copy link
Member

@lucklove lucklove commented Jan 8, 2021

What problem does this PR solve?

Introduced by #1044, TiUP can't notice that the TiDBSpec don't have DataDir and will render an empty string

What is changed and how it works?

Convert pointer to struct it point to if the s of renderSpec is a pointer.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot requested a review from breezewish January 8, 2021 08:56
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 8, 2021
@codecov-io
Copy link

codecov-io commented Jan 8, 2021

Codecov Report

Merging #1049 (0170126) into master (65f061d) will decrease coverage by 4.16%.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1049      +/-   ##
==========================================
- Coverage   55.94%   51.78%   -4.17%     
==========================================
  Files         282      282              
  Lines       19860    19868       +8     
==========================================
- Hits        11111    10288     -823     
- Misses       7029     7956     +927     
+ Partials     1720     1624      -96     
Flag Coverage Δ
cluster 38.35% <0.00%> (-5.67%) ⬇️
dm 23.94% <0.00%> (-0.08%) ⬇️
integrate 46.02% <0.00%> (-4.24%) ⬇️
playground 20.31% <ø> (ø)
tiup 16.48% <ø> (-0.03%) ⬇️
unittest 22.28% <20.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/manager/transfer.go 10.66% <20.00%> (-44.56%) ⬇️
components/cluster/command/check.go 6.73% <0.00%> (-72.76%) ⬇️
pkg/cluster/task/limits.go 0.00% <0.00%> (-68.75%) ⬇️
pkg/cluster/task/sysctl.go 0.00% <0.00%> (-66.67%) ⬇️
pkg/cluster/task/copy_file.go 0.00% <0.00%> (-54.55%) ⬇️
components/cluster/command/audit.go 27.27% <0.00%> (-54.55%) ⬇️
pkg/cluster/operation/check.go 0.00% <0.00%> (-53.07%) ⬇️
pkg/cluster/manager/patch.go 0.00% <0.00%> (-51.81%) ⬇️
pkg/cluster/task/rmdir.go 0.00% <0.00%> (-50.00%) ⬇️
pkg/cluster/manager/cleanup.go 0.00% <0.00%> (-49.19%) ⬇️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65f061d...0170126. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 8, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4d631a7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 8, 2021
@ti-chi-bot ti-chi-bot merged commit df76e55 into pingcap:master Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants