-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement checkpoint #1069
Implement checkpoint #1069
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1069 +/- ##
==========================================
+ Coverage 56.41% 56.54% +0.13%
==========================================
Files 278 283 +5
Lines 19696 19970 +274
==========================================
+ Hits 11111 11293 +182
- Misses 6862 6928 +66
- Partials 1723 1749 +26
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/hold |
/hold cancel |
Co-authored-by: Allen Zhong <allen@moe.cat>
Co-authored-by: Allen Zhong <allen@moe.cat>
/lgtm |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: fdc4771
|
@lucklove: Your PR has out-of-dated, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Close #1026
What is changed and how it works?
Implement a cache struct (
CheckPointExecutor
) overlayExecutor
, which writes the results ofExecutor
to auth log and read them back when in checkpoint mode:If user specify the
--checkpoint
flag,theCheckPointExecutor
will read all checkpoints from the specified auth log and use them as the cache. After that, when there is a command should be execute in remote, it will check if it's exists in the cache, if so, use the cached result directly, otherwise, call realExecutor
and records it's result to current auth log.Check List
Tests
Side effects
Related changes
Release notes: