Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: update depends & CI jobs #1130

Merged
merged 3 commits into from
Feb 19, 2021

Conversation

AstroProfundis
Copy link
Contributor

@AstroProfundis AstroProfundis commented Feb 4, 2021

What problem does this PR solve?

Update go mod dependencies, after this PR the code can be compiled with Go 1.16 for darwin/arm64. (for #1122)

Also update Github Actions jobs to use Go 1.16.

Check List

Tests

  • Unit test

Release notes:

NONE

@AstroProfundis AstroProfundis added type/enhancement Categorizes issue or PR as related to an enhancement. category/testing Categorizes issue or PR as a testing enhancement. labels Feb 4, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@AstroProfundis AstroProfundis self-assigned this Feb 4, 2021
@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 4, 2021
@codecov-io
Copy link

codecov-io commented Feb 4, 2021

Codecov Report

Merging #1130 (54e9afb) into master (97cd5cb) will decrease coverage by 15.08%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1130       +/-   ##
===========================================
- Coverage   56.57%   41.49%   -15.09%     
===========================================
  Files         285      251       -34     
  Lines       20258    17401     -2857     
===========================================
- Hits        11461     7220     -4241     
- Misses       7032     8977     +1945     
+ Partials     1765     1204      -561     
Flag Coverage Δ
cluster 38.33% <25.00%> (-6.59%) ⬇️
dm 25.49% <50.00%> (-0.03%) ⬇️
integrate 41.49% <50.00%> (-9.51%) ⬇️
playground ?
tiup ?
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/repository/progress.go 30.00% <ø> (-70.00%) ⬇️
pkg/cliutil/tui.go 59.18% <33.33%> (ø)
pkg/cluster/api/dmapi.go 60.00% <100.00%> (-2.61%) ⬇️
pkg/repository/store/store.go 0.00% <0.00%> (-100.00%) ⬇️
components/dm/ansible/worker.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/queue/any_queue.go 0.00% <0.00%> (-83.34%) ⬇️
pkg/repository/utils/hash.go 0.00% <0.00%> (-81.82%) ⬇️
pkg/meta/err.go 0.00% <0.00%> (-81.25%) ⬇️
pkg/telemetry/meta.go 0.00% <0.00%> (-80.00%) ⬇️
pkg/telemetry/scrub.go 6.66% <0.00%> (-80.00%) ⬇️
... and 137 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97cd5cb...54e9afb. Read the comment docs.

@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 10, 2021
@AstroProfundis AstroProfundis force-pushed the update-depends branch 3 times, most recently from 52c389a to abed92f Compare February 18, 2021 10:53
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 18, 2021
@AstroProfundis AstroProfundis changed the title *: update depends *: update depends & CI jobs Feb 18, 2021
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 18, 2021
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 18, 2021
@AstroProfundis AstroProfundis merged commit 39532ee into pingcap:master Feb 19, 2021
@AstroProfundis AstroProfundis deleted the update-depends branch February 19, 2021 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category/testing Categorizes issue or PR as a testing enhancement. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/enhancement Categorizes issue or PR as related to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants