Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: tiup: update reprotest task #152

Merged
merged 3 commits into from
Feb 24, 2021
Merged

feat: tiup: update reprotest task #152

merged 3 commits into from
Feb 24, 2021

Conversation

AstroProfundis
Copy link
Contributor

reprotest 1.16 added in pingcap/tiup#1130
reprotest 1.13 removed in pingcap/tiup#1151

So update the CI config.

@ti-chi-bot
Copy link
Member

Hi @AstroProfundis. Thanks for your PR.

I'm waiting for a ti-community-infra member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 23, 2021
@AstroProfundis AstroProfundis changed the title tiup: update reprotest task update: tiup: adjust reprotest task Feb 23, 2021
@AstroProfundis AstroProfundis changed the title update: tiup: adjust reprotest task feat: tiup: update reprotest task Feb 23, 2021
@Rustin170506
Copy link
Contributor

/ok-to-test

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Feb 23, 2021
@Rustin170506
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hi-rustin

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 23, 2021
@Rustin170506
Copy link
Contributor

/hold

/merge

@AstroProfundis Please feel free unhold it.

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 23, 2021
@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0e7562b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 23, 2021
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Feb 23, 2021
@Rustin170506
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6f8f905

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 23, 2021
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Feb 23, 2021
@Rustin170506 Rustin170506 added the sig/tiup Indicates that the Issue or PR belongs to the tiup SIG. label Feb 23, 2021
@Rustin170506
Copy link
Contributor

Rustin170506 commented Feb 23, 2021 •
edited
Loading

@AstroProfundis I added the sig/tiup label, now you can merge it by yourself.

@AstroProfundis
Copy link
Contributor Author

/unhold

/merge

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 24, 2021
@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: def3ab8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 24, 2021
@ti-chi-bot ti-chi-bot merged commit 5c4256e into ti-community-infra:main Feb 24, 2021
@ti-chi-bot
Copy link
Member

@AstroProfundis: Updated the config configmap in namespace prow at cluster default using the following files:

  • key config.yaml using file prow/config/config.yaml

In response to this:

reprotest 1.16 added in pingcap/tiup#1130
reprotest 1.13 removed in pingcap/tiup#1151

So update the CI config.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AstroProfundis AstroProfundis deleted the update-tiup-gover branch February 24, 2021 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rustin170506 Rustin170506 Awaiting requested review from Rustin170506

@Mini256 Mini256 Awaiting requested review from Mini256

Assignees
No one assigned
Labels
ok-to-test Indicates a PR is ready to be tested. sig/tiup Indicates that the Issue or PR belongs to the tiup SIG. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AstroProfundis @ti-chi-bot @Rustin170506