Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: ignore error when increasing schedule limit during upgrade #1359

Merged
merged 2 commits into from
May 17, 2021

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

Fix #1339

What is changed and how it works?

The error report when increasing schedule limit should be able to be safely ignored, as if we failed to change it, things are remained unchanged, and all operations should still be processed with the current settings.

Check List

Related changes

  • Need to cherry-pick to the release branch

Release notes:

cluster: ignore error when increasing schedule limit during upgrade

@AstroProfundis AstroProfundis added the component/cluster Issues about the tiup-cluster component label May 12, 2021
@AstroProfundis AstroProfundis requested a review from lucklove May 12, 2021 09:35
@AstroProfundis AstroProfundis self-assigned this May 12, 2021
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 12, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 12, 2021

Codecov Report

Merging #1359 (940fc07) into master (5059068) will increase coverage by 18.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1359       +/-   ##
===========================================
+ Coverage   25.38%   43.41%   +18.03%     
===========================================
  Files         265      255       -10     
  Lines       20464    19269     -1195     
===========================================
+ Hits         5194     8365     +3171     
+ Misses      14473     9512     -4961     
- Partials      797     1392      +595     
Flag Coverage Δ
cluster 41.14% <0.00%> (?)
dm 24.70% <0.00%> (?)
integrate 43.41% <0.00%> (+27.88%) ⬆️
tiup ?
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/operation/upgrade.go 57.27% <0.00%> (ø)
pkg/utils/regexp.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/repository/store/store.go 0.00% <0.00%> (-100.00%) ⬇️
components/dm/ansible/worker.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/repository/utils/hash.go 0.00% <0.00%> (-81.82%) ⬇️
pkg/meta/err.go 0.00% <0.00%> (-81.25%) ⬇️
pkg/telemetry/telemetry.go 0.00% <0.00%> (-80.00%) ⬇️
pkg/utils/semver.go 6.95% <0.00%> (-78.27%) ⬇️
pkg/repository/store/local.go 0.00% <0.00%> (-76.48%) ⬇️
pkg/cluster/api/error.go 0.00% <0.00%> (-75.00%) ⬇️
... and 247 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5059068...940fc07. Read the comment docs.

@AstroProfundis AstroProfundis added this to the v1.4.4 milestone May 13, 2021
@lucklove
Copy link
Member

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 17, 2021
@lucklove
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c330e77

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 17, 2021
@ti-chi-bot ti-chi-bot merged commit 7f3c663 into pingcap:master May 17, 2021
@AstroProfundis AstroProfundis deleted the issue-1339 branch May 17, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/cluster Issues about the tiup-cluster component size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tiup cluster upgrade dba-test --force "code 500"
4 participants