Fix tiflash start script

[lucklove]

Fix #642

[codecov-io]

Codecov Report

Merging #984 (96b4909) into master (91466ae) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #984      +/-   ##
==========================================
+ Coverage   55.41%   55.42%   +0.01%     
==========================================
  Files         279      279              
  Lines       19709    19709              
==========================================
+ Hits        10921    10923       +2     
+ Misses       7070     7064       -6     
- Partials     1718     1722       +4     

Flag	Coverage Δ
cluster	43.26% <100.00%> (+0.01%)	⬆️
dm	23.81% <100.00%> (ø)
integrate	49.68% <100.00%> (+0.01%)	⬆️
playground	20.29% <ø> (ø)
tiup	16.45% <100.00%> (ø)
unittest	23.08% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/cluster/embed/autogen_pkger.go	100.00% <100.00%> (ø)
pkg/cluster/template/scripts/pd.go	68.75% <0.00%> (-3.13%)	⬇️
pkg/cluster/spec/pd.go	68.71% <0.00%> (-2.46%)	⬇️
pkg/cluster/api/pdapi.go	61.30% <0.00%> (-0.31%)	⬇️
pkg/cluster/spec/tikv.go	57.63% <0.00%> (+1.47%)	⬆️
pkg/utils/retry.go	65.78% <0.00%> (+15.78%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91466ae...96b4909. Read the comment docs.

[9547]

BTW, >> log/tiflash_stderr.log will only append the stderr log into file, but issue #642 seems to say the tiflash/logs not created?

[lucklove]

BTW, >> log/tiflash_stderr.log will only append the stderr log into file, but issue #642 seems to say the tiflash/logs not created?

Good question. The log directory is empty is because the tiflash didn't start at all (it should be start by numactl but there is no numactl found), so there is no opportunity for it to create a log file.

[9547]

BTW, >> log/tiflash_stderr.log will only append the stderr log into file, but issue #642 seems to say the tiflash/logs not created?

Good question. The log directory is empty is because the tiflash didn't start at all (it should be start by numactl but there is no numactl found), so there is no opportunity for it to create a log file.

I got it. I previously thought that issue want to say the log dir is missing, not the log files under log dir is missing 🐻

[glkappe]

BTW, >> log/tiflash_stderr.log will only append the stderr log into file, but issue #642 seems to say the tiflash/logs not created?

Good question. The log directory is empty is because the tiflash didn't start at all (it should be start by numactl but there is no numactl found), so there is no opportunity for it to create a log file.

So in files changed, does the final execution of the command change?
Newly added command line parameter 2>> "{{.LogDir}}/tiflash_stderr.log, the output content should be printed in cmd.
So we can still locate the cause of the tiflash startup failure before v1.3.0 ?

[9547]

this behavior is the same as other components, we use systemctl to start/stop those components, if start failed,the error message was omited, and you can check the error log for more detail.