Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use stable Kotlin compiler frontend #1506

Merged
merged 2 commits into from
Jun 20, 2022
Merged

Use stable Kotlin compiler frontend #1506

merged 2 commits into from
Jun 20, 2022

Conversation

3flex
Copy link
Contributor

@3flex 3flex commented Jun 19, 2022 •
edited
Loading

Description

Using K2 means library consumers must also use the new compiler (and may not be ready to), otherwise they will have errors like "<classname> is compiled by the new Kotlin compiler frontend and cannot be loaded by the old compiler"

Checklist

  • PR description added
  • tests are added
  • CHANGELOG.md is updated

In case of adding a new rule:

  • README.md is updated
  • Rule has been applied on Ktlint itself and violations are fixed

@3flex
Use stable Kotlin compiler frontend
f57cbe3 
Using K2 means library consumers must also
update, otherwise they will have errors like
"<classname> is compiled by the new Kotlin
compiler frontend and cannot be loaded by the old
compiler"
@3flex 3flex mentioned this pull request Jun 19, 2022
Closed
1 task
@paul-dingemans
Copy link
Collaborator

Sorry, that was not intended. We will revert that change this week. @Goooler

@3flex
Copy link
Contributor Author

3flex commented Jun 19, 2022

If by "revert" you mean downgrading from Kotlin 1.7, that shouldn't be necessary. It just needs to stop using the K2 compiler mode.

@Goooler
Copy link
Contributor

Goooler commented Jun 20, 2022

Should we note this change in the changelog?

@paul-dingemans paul-dingemans added this to the 0.46.1 milestone Jun 20, 2022
@paul-dingemans
Copy link
Collaborator

Should we note this change in the changelog?

yes

Should we note this change in the changelog?

Yes and done so.

@shashachu
Copy link
Contributor

thanks!

@shashachu shashachu merged commit 60d412a into pinterest:master Jun 20, 2022
@3flex 3flex deleted the patch-1 branch June 20, 2022 21:50
@orchestr7
Copy link
Contributor

@3flex thank you for this PR - yesterday we spent the whole day for trying to stabilise the build on K2 😂 in diktat. We were afraid of @paul-dingemans and there was such a fear that we decided not even to report it to ktlint 😂😂😂

@paul-dingemans
Copy link
Collaborator

That sounds a bit rough to say. You should never fear the conversation with me. We all make mistakes. As open source developers we are all dedicated to make the world better even if we sometimes have different opinions.

@orchestr7
Copy link
Contributor

That sounds a bit rough to say. You should never fear the conversation with me. We all make mistakes. As open source developers we are all dedicated to make the world better even if we sometimes have different opinions.

I’m just kidding 🙏 just an inside joke related to our last arguing about RuleSetProvider 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Goooler Goooler Goooler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.46.1
Development

Successfully merging this pull request may close these issues.
5 participants
@3flex @paul-dingemans @Goooler @shashachu @orchestr7