-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use stable Kotlin compiler frontend #1506
Conversation
Using K2 means library consumers must also update, otherwise they will have errors like "<classname> is compiled by the new Kotlin compiler frontend and cannot be loaded by the old compiler"
Sorry, that was not intended. We will revert that change this week. @Goooler |
If by "revert" you mean downgrading from Kotlin 1.7, that shouldn't be necessary. It just needs to stop using the K2 compiler mode. |
Should we note this change in the changelog? |
yes
Yes and done so. |
thanks! |
@3flex thank you for this PR - yesterday we spent the whole day for trying to stabilise the build on K2 😂 in diktat. We were afraid of @paul-dingemans and there was such a fear that we decided not even to report it to ktlint 😂😂😂 |
That sounds a bit rough to say. You should never fear the conversation with me. We all make mistakes. As open source developers we are all dedicated to make the world better even if we sometimes have different opinions. |
I’m just kidding 🙏 just an inside joke related to our last arguing about RuleSetProvider 😁 |
Description
Using K2 means library consumers must also use the new compiler (and may not be ready to), otherwise they will have errors like "<classname> is compiled by the new Kotlin compiler frontend and cannot be loaded by the old compiler"
Checklist
CHANGELOG.md
is updatedIn case of adding a new rule:
README.md
is updated