Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ktlint v0.46.* #1379

Merged
merged 11 commits into from
Jun 22, 2022
Merged

Support ktlint v0.46.* #1379

merged 11 commits into from
Jun 22, 2022

Conversation

nulls
Copy link
Member

@nulls nulls commented Jun 21, 2022

No description provided.

@nulls nulls self-assigned this Jun 21, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 21, 2022

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v1)

1 261 tests  +1 259   1 245 ✔️ +1 243   8m 22s ⏱️ + 8m 20s
   151 suites +   150        16 💤 +     16 
   151 files   +   150          0 ±       0 

Results for commit d48c0c0. ± Comparison against base commit f9e9208.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 21, 2022

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v1)

   151 files  +   150     151 suites  +150   8m 34s ⏱️ + 8m 32s
1 261 tests +1 259  1 244 ✔️ +1 242  16 💤 +16  1 +1 
1 262 runs  +1 260  1 245 ✔️ +1 243  16 💤 +16  1 +1 

For more details on these failures, see this check.

Results for commit d48c0c0. ± Comparison against base commit f9e9208.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #1379 (d48c0c0) into renovate/ktlint (c0b42a8) will increase coverage by 0.08%.
The diff coverage is 61.53%.

@@                  Coverage Diff                  @@
##             renovate/ktlint    #1379      +/-   ##
=====================================================
+ Coverage              83.30%   83.39%   +0.08%     
+ Complexity              2554     2540      -14     
=====================================================
  Files                    107      106       -1     
  Lines                   7565     7610      +45     
  Branches                2090     2087       -3     
=====================================================
+ Hits                    6302     6346      +44     
- Misses                   373      374       +1     
  Partials                 890      890              
Flag Coverage Δ
unittests 83.39% <61.53%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...fn/diktat/common/config/rules/RulesConfigReader.kt 32.20% <ø> (ø)
...qfn/diktat/plugin/gradle/DiktatJavaExecTaskBase.kt 86.53% <ø> (ø)
...cqfn/diktat/ruleset/rules/DiktatRuleSetProvider.kt 97.03% <ø> (+0.02%) ⬆️
...lin/org/cqfn/diktat/plugin/maven/DiktatBaseMojo.kt 52.94% <20.00%> (+1.39%) ⬆️
...tlin/org/cqfn/diktat/ruleset/utils/AstNodeUtils.kt 83.14% <83.33%> (+0.34%) ⬆️
.../kotlin/org/cqfn/diktat/plugin/maven/DiktatMojo.kt 92.30% <100.00%> (+8.97%) ⬆️
...otlin/org/cqfn/diktat/ruleset/utils/StringUtils.kt 82.85% <0.00%> (-5.03%) ⬇️
...cqfn/diktat/ruleset/utils/PositionInTextLocator.kt 92.50% <0.00%> (-2.50%) ⬇️
...g/cqfn/diktat/ruleset/rules/chapter3/EmptyBlock.kt 74.57% <0.00%> (-1.70%) ⬇️
...kotlin/org/cqfn/diktat/ruleset/rules/DiktatRule.kt 65.21% <0.00%> (-1.45%) ⬇️
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0b42a8...d48c0c0. Read the comment docs.

@nulls nulls requested review from petertrr and orchestr7 June 21, 2022 07:48
@nulls nulls marked this pull request as ready for review June 21, 2022 07:48
@nulls nulls changed the title Support ktlint Support ktlint v0.46.0 Jun 21, 2022
* @param pred a predicate
* @return filtered sequence
*/
private fun <T> Sequence<T>.takeWhileInclusive(pred: (T) -> Boolean): Sequence<T> {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have to move to this place because of a bug in kotlin-maven-plugin (will look at it later)

examples/gradle-kotlin-dsl/build.gradle.kts Outdated Show resolved Hide resolved
@renovate renovate bot force-pushed the renovate/ktlint branch 3 times, most recently from b86826b to 6ddef3c Compare June 21, 2022 19:47
### What's done:
- enabled K2 compiler where it's require
- supported removed classes and fields
### What's done:
- enabled K2 compiler where it's require
- supported removed classes and fields
@nulls nulls changed the title Support ktlint v0.46.0 Support ktlint v0.46.* Jun 22, 2022
@nulls nulls merged commit 677a0ca into renovate/ktlint Jun 22, 2022
@nulls nulls deleted the feature/renovate/ktlint branch June 22, 2022 11:53
nulls added a commit that referenced this pull request Jun 22, 2022
* Update Ktlint to v0.46.1
* enabled K2 compiler where it's require (after v0.46.0)
* supported removed classes and fields

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
nulls added a commit that referenced this pull request Jun 22, 2022
* Update Ktlint to v0.46.1
* enabled K2 compiler where it's require (after v0.46.0)
* supported removed classes and fields

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
nulls pushed a commit that referenced this pull request Jun 22, 2022
* Support ktlint v0.46.* (#1379)
* enabled K2 compiler where it's require (after v0.46.0)
* supported removed classes and fields

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants