Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests parallelly on CI #1787

Merged
merged 5 commits into from
Jan 30, 2023
Merged

Conversation

Goooler
Copy link
Contributor

@Goooler Goooler commented Jan 23, 2023

Description

This is a regression of using toolchain, reverts some changes in #1294 & #1453 to save more time on CI, especially for the Windows related builds. More result diffs you can see Goooler#39.

Checklist

  • PR description added
  • tests are added
  • KtLint has been applied on source code itself and violations are fixed
  • documentation is updated
  • CHANGELOG.md is updated

In case of adding a new rule:

Revert some changes in 2ba00cd to save more time on CI.
@Goooler Goooler changed the title Run tests parallelly on CI (#39) Run tests parallelly on CI Jan 23, 2023
@shashachu
Copy link
Contributor

@Goooler i fixed the issue with the PR build; you should be able to rebase and re-run the checks.

@paul-dingemans
Copy link
Collaborator

@Goooler Can you have another look? I think the 'old' jobs need to be removed as the build now keeps waiting.

@Goooler
Copy link
Contributor Author

Goooler commented Jan 26, 2023

That might be related to the status check in repo settings, see https://stackoverflow.com/a/69169858/19772203.

@shashachu Can you take a look this in settings?

@Goooler
Copy link
Contributor Author

Goooler commented Jan 28, 2023

@paul-dingemans No need to note this change, it's not user noticeable.

@shashachu
Copy link
Contributor

@Goooler @paul-dingemans i updated the required checks for merging. we will have to update this whenever we change the build jdk versions, but that shouldn't be a huge deal.

thanks for this change! i have also noticed the windows build takes forever now.

@shashachu shashachu merged commit 2aa83e1 into pinterest:master Jan 30, 2023
@shashachu
Copy link
Contributor

For future reference (for myself and any other admins we may add in the future), the checks are in Settings -> Branches -> Branch protection rules (master). I had to delete the old checks and add the new ones here:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants