Adding experimental rule for detecting first line blank in method block #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The pipeline seems to fail with compilation error for the new test classes as it is unable to resolve the dependency. It runs fine in local though. |
| import com.pinterest.ktlint.test.format | ||
| import com.pinterest.ktlint.test.lint | ||
| import org.assertj.core.api.Assertions.assertThat | ||
| import org.testng.annotations.Test |
There was a problem hiding this comment.
This is the wrong import. You need to use import org.junit.Test.
There was a problem hiding this comment.
All the other tests use this import import org.testng.annotations.Test though
There was a problem hiding this comment.
The do not anymore. Can you please rebase with master?
git rebase -i origin/master
There was a problem hiding this comment.
Ah ! Got it.. Will fix it..
|
Fix the import and then rebase with master. After that, you should be good. |
sowmyav24
force-pushed
the
no-first-line-blank-in-method-block-rule
branch
4 times, most recently
from
9409c9f
to
54bc41d
Compare
* Adding CHANGELOG for 0.33.0, updating various version references * Adding another issue fixed in 0.33.0
And made command line options style consistent. Signed-off-by: Yahor Berdnikau <egorr.berd@gmail.com>
…Main' to 'com.pinterest.ktlint.Main' (pinterest#465)
* Update picoli to latest stable 3.9.6 release. Changelog: https://github.com/remkop/picocli/blob/master/RELEASE-NOTES.md#-picocli-396 Signed-off-by: Yahor Berdnikau <egorr.berd@gmail.com> * Replace shyiko with pinterest in command line messages. Signed-off-by: Yahor Berdnikau <egorr.berd@gmail.com>
sowmyav24
force-pushed
the
no-first-line-blank-in-method-block-rule
branch
from
f106346
to
3337ee9
Compare
|
Fixed all rebase issues and created a PR #474 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This experimental rule addresses issue Issue #440.
In addition to checking for first line blank in a method block, it will check for any first blank line in code blocks of the method.Please let me know if the subsequent code blocks in the method need to be ignored from this check.
Due to this new rule, there were violations reported in the code. Have fixed them also.