Skip to content

Commit

Permalink
magento#10045 Fix coding standards
Browse files Browse the repository at this point in the history
  • Loading branch information
piotrkwiecinski committed Jul 23, 2017
1 parent d990c95 commit 79d15ad
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public function testGetItems(array $categories)
$resolver = new CategorySitemapItemResolver($storeConfigMock, $cmsPageFactoryMock, $itemFactoryMock);
$items = $resolver->getItems(1);
self::assertTrue(count($items) == count($categories));
foreach($categories as $index => $category) {
foreach ($categories as $index => $category) {
self::assertSame($category->getUpdatedAt(), $items[$index]->getUpdatedAt());
self::assertSame('daily', $items[$index]->getChangeFrequency());
self::assertSame('1.0', $items[$index]->getPriority());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -149,4 +149,4 @@ private function getCmsPageCollectionMock($returnValue)

return $sitemapCmsPageMock;
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@

class CompositeSitemapItemResolverTest extends \PHPUnit_Framework_TestCase
{
public function testNoResolvers() {
public function testNoResolvers()
{
$resolver = new CompositeSitemapItemResolver();
self::assertSame([], $resolver->getItems(1));
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,24 +34,24 @@ public function testGetItemsEmpty()

/**
* @dataProvider productProvider
* @param array $categories
* @param array $products
*/
public function testGetItems(array $categories)
public function testGetItems(array $products)
{
$storeConfigMock = $this->getStoreConfigMock([
ProductSitemapItemResolver::XML_PATH_PRODUCT_CHANGEFREQ => 'daily',
ProductSitemapItemResolver::XML_PATH_PRODUCT_PRIORITY => '1.0',
]);

$ProductMock = $this->getProductCollectionMock($categories);
$ProductMock = $this->getProductCollectionMock($products);

$cmsPageFactoryMock = $this->getProductFactoryMock($ProductMock);
$itemFactoryMock = $this->getItemFactoryMock();

$resolver = new ProductSitemapItemResolver($storeConfigMock, $cmsPageFactoryMock, $itemFactoryMock);
$items = $resolver->getItems(1);
self::assertTrue(count($items) == count($categories));
foreach($categories as $index => $product) {
self::assertTrue(count($items) == count($products));
foreach ($products as $index => $product) {
self::assertSame($product->getUpdatedAt(), $items[$index]->getUpdatedAt());
self::assertSame('daily', $items[$index]->getChangeFrequency());
self::assertSame('1.0', $items[$index]->getPriority());
Expand Down Expand Up @@ -171,4 +171,4 @@ private function getProductCollectionMock($returnValue)

return $sitemapCmsPageMock;
}
}
}

0 comments on commit 79d15ad

Please sign in to comment.