-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
comply to PEP8 #10
Comments
Scheduled for 0.8.0. I'll probably add some wrappers to print |
Changed all function/variable names, commit 361003c3772cba677a80a57e0a7c3e648f42f6e0 . There is no |
reopening (forgot to change and test documentation as well :F ) |
* backwards incompatible, breaks all existing code! * but the changes are straightforward: numTopics => num_topics, addDocuments => add_documents etc. * documentation to be updated in a separate commit
Documentation updated in commit 88f2a3b . All of gensim is now proper PEP8! |
This is not the case anymore, (e.g. pyflake shows 63 warnings for |
@mcobzarenco what warnings are these? For example, we care more about readability than a strict 80-char-line limit. But I also noticed some lapses (vertical indent in word2vec). @menshikh-iv what's the status on code style consistency in gensim? |
(math) ivan@P50:~/release/gensim$ git log | head -n5
commit e92b45d3f83ad670da9cf6ae20ae86a2a1c8558c
Author: jodevak <jodevak@users.noreply.github.com>
Date: Thu Oct 19 09:37:41 2017 +0300
Add build_vocab_from_freq to Word2Vec, speedup scan_vocab (#1599)
(math) ivan@P50:~/release/gensim$ find gensim/ -name "*.py" | xargs flake8 --ignore=E501,E731,E12,W503,E402 --show-source
gensim/test/test_lsimodel.py:95:5: E303 too many blank lines (2)
def testCorpusTransform(self):
^ |
Right, fair enough, all of the warnings were of the types you ignore above. Do you think we could we add those ignored rules to |
Change
camelCase
vars and function names and parameters topython_style
. This will break backward compatibility, so it best be done all at once (rather than incrementally).http://groups.google.com/group/gensim/browse_thread/thread/73f4301723cea765
The text was updated successfully, but these errors were encountered: