-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pep8 exceptions for flake8 in setup.cfg #1636
Conversation
@mcobzarenco hi, please update current flake8 run https://github.com/RaRe-Technologies/gensim/blob/develop/continuous_integration/travis/flake8_diff.sh#L143 and https://github.com/RaRe-Technologies/gensim/blob/develop/continuous_integration/travis/flake8_diff.sh#L153 |
ping @mcobzarenco |
Sorry for the delay -- ok, so:
|
One thing to keep in mind with the current way of running One fix for the former would be for |
@mcobzarenco please add |
|
Thanks, congratz with first contribution @mcobzarenco 👍 |
Thanks for merging! |
#10 suggests that the code style of
gensim
should ignore flake8'sE501,E731,E12,W503,E402
This PR adds the rules to
setup.cfg
so they're documented and used by default.